Tests: repair the Generation tests on Windows #6354
+72
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirror the `testOnLinux` for Windows with a `testOnWindows`. This allows us to skip some tests dynamically as we do on Linux.
Here's an example of your CHANGELOG entry: * Tests: repair the Generation tests on Windows.
[compnerd](https://github.com/compnerd)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Windows isolates XCTest/Testing from the platform SDK as they are not part of the redistributable components. We adjust the flags by querying the partial path information and computing the location for the `XCTest` module for the tests. Additionally, enable the ObjC interop on the test cases to allow parsing `@objc` modifiers on declarations. This allows us to pass the GeneratedTests test suite.
Contributor
|
Neat! |
SimplyDanny
approved these changes
Nov 27, 2025
Collaborator
SimplyDanny
left a comment
SimplyDanny
left a comment
There was a problem hiding this comment.
Looks good to me apart from two nits.
We could probably come up with semantically equal test cases that would also work on Windows, but excluding them is also fine as we're not testing anything platform-related. So logic that works on Linux/macOS will also work on Windows anyway.
| .deletingLastPathComponent() | ||
| .deletingLastPathComponent() | ||
| .appendingPathComponent("Library") | ||
| .appendingPathComponent("XCTest-\(info.defaults.versionXCTest)") |
Collaborator
There was a problem hiding this comment.
We could use
Suggested change
| .appendingPathComponent("XCTest-\(info.defaults.versionXCTest)") | |
| .appendingPathComponent("XCTest-\(SwiftVersion.current.rawValue)") |
here which directly interacts with SourceKit to retrieve the version. Not sure whether it's safe to assume that Swift version == XCTest version, though. For the 6.2.1 toolchain, that's the case.
Contributor
Author
There was a problem hiding this comment.
I don't think that is entirely safe to assume (though it does currently hold). That is the reason for the deserialisation of the plist - it encodes the information for the SDK itself which is embedded at build time.
Collaborator
|
Relates to #6352. |
Co-authored-by: Danny Mösch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for testing SwiftLint rule examples on Windows, alongside existing support for Linux and macOS. The most significant changes include introducing a new
testOnWindowsproperty to theExamplemodel, updating rule example definitions to use this property, and modifying test helpers to conditionally run tests based on platform. Additionally, Windows-specific logic for test setup has been added to ensure compatibility.Platform support enhancements:
testOnWindowsproperty to theExamplestruct and updated its initializer to allow specifying whether an example should be tested on Windows. (Source/SwiftLintCore/Models/Example.swift) [1] [2]testOnWindows: falseflag where appropriate, ensuring tests are only run on supported platforms. (Source/SwiftLintBuiltInRules/Rules/Lint/UnusedImportRuleExamples.swift) [1] [2] [3]Test infrastructure improvements:
testOnWindowsproperty before running tests, analogous to the existing Linux checks. (Tests/TestHelpers/TestHelpers.swift)Tests/TestHelpers/TestHelpers.swift) [1] [2]