RCORE-2030 Add full support for automatic client reset for collections in mixed (#7683)

* Add full support for automatic client reset for collections in mixed

* Changes after code review

* Add more tests for better coverage

* Update changelog

* Add integration test and bump baas version

Author: danieltabacaru

CHANGELOG.md

@@ -2,12 +2,13 @@
 
 ### Enhancements
 * <New feature description> (PR [#????](https://github.com/realm/realm-core/pull/????))
-* None.
+* Nested collections have full support for automatic client reset ([PR #7683](https://github.com/realm/realm-core/pull/7683)).
 
 ### Fixed
 * <How do the end-user experience this issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?)
 * Accessing App::current_user() from within a notification produced by App:switch_user() (which includes notifications for a newly logged in user) would deadlock ([#7670](https://github.com/realm/realm-core/issues/7670), since v14.6.0).
 * Inserting the same typed link to the same key in a dictionary more than once would incorrectly create multiple backlinks to the object. This did not appear to cause any crashes later, but would have affecting explicit backlink count queries (eg: `...@links.@count`) and possibly notifications ([#7676](https://github.com/realm/realm-core/issues/7676) since v14.5.2).
+* Automatic client reset recovery would crash when recovering AddInteger instructions on a Mixed property if its type was changed to non-integer ([PR #7683](https://github.com/realm/realm-core/pull/7683), since v11.16.0).
 
 ### Breaking changes
 * None.

dependencies.yml

@@ -3,5 +3,5 @@ VERSION: 14.6.2
 OPENSSL_VERSION: 3.2.0
 ZLIB_VERSION: 1.2.13
 # https://github.com/10gen/baas/commits
-# 5138f5c is 2024 Apr 19
-BAAS_VERSION: 5138f5c924f9f376d31cbc2b1819e1d934600277
+# 9d1b4d6 is 2024 May 8
+BAAS_VERSION: 9d1b4d628babadfb606ebcadb93b1e5cae3c9565

src/realm/object_converter.cpp

@@ -51,6 +51,7 @@ struct InterRealmValueConverter {
     int cmp_src_to_dst(Mixed src, Mixed dst, ConversionResult* converted_src_out = nullptr,
                        bool* did_update_out = nullptr) const;
     void copy_value(const Obj& src_obj, Obj& dst_obj, bool* update_out);
+    void copy_list(const LstBase& src_list, LstBase& dst_list) const;
 
 private:
     void copy_list(const LstBase& src_obj, LstBase& dst_obj, bool* update_out) const;
@@ -63,10 +64,10 @@ struct InterRealmValueConverter {
                             CollectionType type) const;
     void copy_dictionary_in_mixed(const Dictionary& src_list, Dictionary& dst_list, StringData key,
                                   CollectionType type) const;
-    bool check_matching_list(const Lst<Mixed>& src_list, Lst<Mixed>& dst_list, size_t ndx_src, size_t ndx_dst,
-                             CollectionType type) const;
-    bool check_matching_dictionary(const Dictionary& src_list, const Dictionary& dst_list, StringData key,
-                                   CollectionType type) const;
+    bool check_if_list_elements_match(const Lst<Mixed>& src_list, Lst<Mixed>& dst_list, size_t ndx_src,
+                                      size_t ndx_dst) const;
+    bool check_if_dictionary_elements_match(const Dictionary& src_list, const Dictionary& dst_list,
+                                            StringData key) const;
     bool is_collection(Mixed) const;
     CollectionType to_collection_type(Mixed) const;
 

src/realm/object_converter.hpp

@@ -399,6 +399,7 @@ void Changeset::Reflector::operator()(const Instruction::Clear& p) const
 {
     m_tracer.name("Clear");
     path_instr(p);
+    m_tracer.field("collection_type", p.collection_type);
 }
 
 void Changeset::Reflector::operator()(const Instruction::SetInsert& p) const