Fix a crash when beginning an async write triggers notifications which close the Realm #6548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/close-in-async-begin
branch
2 times, most recently
from
a217db7 to
370bac4
Compare
…h close the Realm Beginning a write transaction can result in the Realm being closed as it can trigger notifications, and the async write loop was missing a check for this.
tgoyne
force-pushed
the
tg/close-in-async-begin
branch
from
370bac4 to
28b62af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning a write transaction can result in the Realm being closed as it can trigger notifications, and the async write loop was missing a check for this.