RJS-2854: Adding a ThreadSafeFunction-based scheduler for Core on Node.js#6800
Draft
kraenhansen wants to merge 6 commits intomainfrom
Draft
RJS-2854: Adding a ThreadSafeFunction-based scheduler for Core on Node.js#6800kraenhansen wants to merge 6 commits intomainfrom
ThreadSafeFunction-based scheduler for Core on Node.js#6800kraenhansen wants to merge 6 commits intomainfrom
Conversation
9c0faa8 to
d5719b4
Compare
added 6 commits
July 19, 2024 15:07
d5719b4 to
88fa4d2
Compare
Contributor
Author
|
I thought my implementation was done, but it turns out tests were still failing 🤔 This is likely never going to get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #6772 by implementing a
utils::Schedulerbased on theNapi::ThreadSafeFunctionprimitive.Note: In order for the uncaught exceptions thrown by the Node.js addon, the node process must be started with a
--force-node-api-uncaught-exceptions-policyflag enabled. This was added under a flag to "not breaking existing running Node-API add-ons.".https://github.com/nodejs/node/blob/cd39578e53d6502de03f15620d15835b86954ac8/src/node_api.cc#L85-L115
Alternatively the following warning will be logged:
☑️ ToDos
EventLoopDispatcher,schedulerWrapBlockingFunctionand throughRealmConfigrealm-core#7903 merge and gets released.enforceUncaughtExceptionPolicytemplate parameter to avoid the warning when throwing uncaught exceptions.Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary@realm/devdocsif documentation changes are needed