feat(cli): add delete workflow restarts functionality by michaelbuchar · Pull Request #759 · reanahub/reana-client

michaelbuchar · 2026-02-03T11:09:22Z

tiborsimko · 2026-02-03T16:37:02Z

reana_client/cli/utils.py

+
+
+# Helpers for deleting restarted workflows
+def _get_workspace_group(full_name: str) -> str | None:


If we abstract out the helper functions, let's give them meaningful names not starting with an underscore.

Also "workspace group" would be a novel concept. We can stick to names as we have them in reana-db regarding run numbers and run_number_major and run_number_minor?

Also, if we make the helper functions separate, please write unit tests for them.

tiborsimko · 2026-02-03T16:38:33Z

reana_client/cli/utils.py

+
+
+# Helpers for deleting restarted workflows
+def _get_workspace_group(full_name: str) -> str | None:


AI: str | None union syntax requires Python 3.10+.

This could be troublesome since we promise to support Python 3.8 and 3.9 still in the reana-client code base.

We could use Optional[str] here?

Should be resolved

tiborsimko · 2026-02-03T16:39:48Z

reana_client/cli/utils.py

+    return f"{base}.{numeric[0]}"
+
+
+def _split_base_and_numeric(full_name: str):


AI: The function lacks return type hint. Something like Tuple[Optional[str], List[str]]?

tiborsimko · 2026-02-03T16:40:31Z

reana_client/cli/utils.py

+    return f"#{'.'.join(numeric)}" if numeric else str(full_name)
+
+
+def _format_run_list(labels, max_labels: int) -> str:


AI: Missing type hint on labels parameter. Perhaps List[str]?

tiborsimko · 2026-02-03T16:41:18Z

reana_client/cli/workflow.py

+                    access_token=access_token,
+                    type="batch",
+                    page=1,
+                    size=1000,


Minor: 1000 is hard-coded here. Please extract it into config.py as we are usually doing for other hard-coded constants.

tiborsimko · 2026-02-03T16:43:50Z

reana_client/cli/workflow.py

+
+            if has_restart_series and include_all_restarts:
+                # Delete workspace once, mark related runs deleted without deleting workspace again
+                primary_identifier = wf_id or full_name


Nomenclature: Call the variable primary_id_or_full_name for clarity? Or workflow_id_or_name as we are calling it elsewhere in the code base.

tiborsimko · 2026-02-03T16:44:35Z

reana_client/cli/workflow.py


    if workflow:
        try:
+


Style: no black after try?

Closes reanahub/reana-ui#448

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 3, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

c92a07f

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from aeae7b3 to c92a07f Compare February 3, 2026 11:12

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 3, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

b4ccb83

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from c92a07f to b4ccb83 Compare February 3, 2026 13:56

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 3, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

d3749d9

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from b4ccb83 to d3749d9 Compare February 3, 2026 13:57

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 3, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

af95380

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from d3749d9 to af95380 Compare February 3, 2026 13:59

tiborsimko reviewed Feb 3, 2026

View reviewed changes

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 5, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

9eea1a7

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from af95380 to 9eea1a7 Compare February 5, 2026 14:31

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 5, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

4809e1f

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from 9eea1a7 to 4809e1f Compare February 5, 2026 14:35

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 5, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

ae450f4

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from 4809e1f to ae450f4 Compare February 5, 2026 14:36

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 5, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

17f013e

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from ae450f4 to 17f013e Compare February 5, 2026 14:45

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 5, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

a0a4b1e

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from 17f013e to a0a4b1e Compare February 5, 2026 15:04

michaelbuchar pushed a commit to michaelbuchar/reana-client that referenced this pull request Feb 5, 2026

feat(cli): add delete workflow restarts functionality (reanahub#759)

1622f45

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from a0a4b1e to 1622f45 Compare February 5, 2026 15:08

feat(cli): add delete workflow restarts functionality (reanahub#759)

fa88484

Closes reanahub/reana-ui#448

michaelbuchar force-pushed the feat/delete-restarted-workflow-removes-original-workflow branch from 1622f45 to fa88484 Compare February 5, 2026 15:10

michaelbuchar marked this pull request as ready for review February 5, 2026 15:12

michaelbuchar self-assigned this Feb 5, 2026



		# Helpers for deleting restarted workflows
		def _get_workspace_group(full_name: str) -> str \| None:

		return f"{base}.{numeric[0]}"


		def _split_base_and_numeric(full_name: str):

		return f"#{'.'.join(numeric)}" if numeric else str(full_name)


		def _format_run_list(labels, max_labels: int) -> str:

Conversation

michaelbuchar commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

michaelbuchar commented Feb 3, 2026 •

edited

Loading