sync: Merge monorepo updates (glm46, serialization tests, workflows) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Actions pinned to full-length commit SHA per GitHub org policy: - actions/checkout@v4 → 34e114876b0b11c390a56381ad16ebd13914f8d5 - dtolnay/rust-toolchain@stable/master → f7ccc83f9ed1e5b9c81d8a67d7ad1a747e22a561 - mozilla-actions/[email protected] → 676c0e67b665684f17941acf5cc3af83bcf10228 - Swatinem/rust-cache@v2 → 779680da715d629ac1d338a641029a2f4372abb5 - actions/upload-artifact@v4 → ea165f8d65b6e75b540449e92b4886f43607fa02 - actions/download-artifact@v4 → d3f86a106a0bac45b974a628896c90dbdf5c8093 - actions/cache@v4 → 0057852bfaa89a56745cba8c7296529d2fc39830 - EmbarkStudios/cargo-deny-action@v1 → ef301417264190a1eb9f26fcf171642070085c5b - gitleaks/gitleaks-action@v2 → dcedce43c6f43de0b836d1fe38946645c9c638dc - and more Fixes CI badge failures across all repos. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Feature-gate glm46 module behind --features glm46 (opt-in) - Fix corrupted syntax in thinktool_profile.rs - Fix error type conversions in ollama.rs and orchestrator.rs - Fix ToolChoice serialization (rename_all lowercase) - Gate internal tests with glm46-internal-tests feature - Add integration tests (glm46_unit_tests, glm46_integration_tests, glm46_performance_validation) - Update README to reflect experimental status - Set default-run = "rk" in reasonkit/Cargo.toml The glm46 module is now experimental and won't break default builds. Enable with: cargo build --features glm46 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Delete dead internal tests gated behind glm46-internal-tests feature (circuit_breaker, client, mcp_server, ollama, orchestrator, thinktool_profile) - Fix all clippy warnings: - Remove unused imports (serde::Deserialize, json!, info) - Replace .and_then(|x| Some(y)) with .map(|x| y) - Replace redundant closures with type references - Replace needless borrows in .get() calls - Replace map_or with is_ok_and - Fix negative multiply pattern - Replace needless Ok(?) with direct return - Fix manual_range_contains patterns - Add Default impl for CostTracker - Export CostTracker from glm46 module - Fix test to use actual CostTracker validation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add 24 new tests for thorough API type validation - Test MessageRole serialization format (lowercase) - Test ChatMessage optional field omission with skip_serializing_if - Test ChatMessage helper constructors (system, user, assistant, tool) - Test ResponseFormat enum serialization (text, json_object, structured, json_schema) - Test ChatRequest full field serialization and round-trip - Test Tool and ToolCall serialization matching OpenAI API format - Test TokenUsage, FinishReason deserialization from mock API responses - Test ChatResponse and StreamChunk deserialization - Test APIError deserialization - Test CircuitBreakerConfig defaults - Test UsageStats calculations and edge cases Total: 36 unit tests now cover GLM-4.6 type system 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Export glm46 module from lib.rs (feature-gated) - Update CLI command name from 'rk-core' to 'rk' - Update documentation examples to use 'rk' command 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Updated GitHub workflow configurations - Updated documentation files - Updated brand assets and SVG diagrams 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR syncs monorepo changes with the OSS repository, including:
- Binary rename from
rk-coretorkacross all scripts, documentation, and code - GLM-4.6 module cleanup with clippy fixes and improved serialization
- Addition of 36 comprehensive serialization tests for GLM-4.6
- Documentation and brand asset updates
- CI workflow synchronization
Reviewed changes
Copilot reviewed 77 out of 86 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/main.rs |
Binary name changed from rk-core to rk |
tests/glm46_* |
New comprehensive test suites for GLM-4.6 (795+ lines of tests) |
src/glm46/*.rs |
Clippy fixes, error handling improvements, serialization fixes |
shell/**/*.zsh |
Updated shell integration for new binary name |
scripts/**/*.sh |
Updated installation and utility scripts for rk binary |
docs/**/*.md |
Updated all documentation references from rk-core to rk |
examples/*.rs |
New GLM-4.6 quick start example |
brand/readme/terminal_mockup.svg |
Updated terminal mockup with new binary name |
The changes appear well-structured and comprehensive, with proper error handling improvements and extensive test coverage for the GLM-4.6 module. The binary rename is consistently applied across all files.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: This syncs the monorepo changes with the OSS repo. The histories diverged due to independent CI commits on both sides, but content is equivalent.
🤖 Generated with Claude Code