Skip to content

fix: ensure footer width conforms to design #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timothyylim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure footer width conforms to design #1404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 39 additions & 35 deletions apps/comps/components/footer-section/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,41 +45,45 @@ export const FooterSection: React.FC<FooterSectionProps> = ({ className }) => {

return (
<footer className={cn("mt-10", className)}>
<div className="xs:grid-cols-5 grid grid-cols-3 content-center gap-8 border-y py-10 font-normal">
<Image
src="/logo_white.svg"
alt="recallnet"
height={72}
width={63}
className="h-[72px] w-[63px]"
/>
<div className="flex flex-col">
{linkBlock1.map(({ text, link }, i) => (
<a
key={i}
href={link}
target="_blank"
rel="noopener noreferrer"
className="text-secondary-foreground mb-0 flex items-center gap-2 font-mono text-xs hover:text-white"
>
<span className="text-md">¬</span>
<span>{text}</span>
</a>
))}
</div>
<div className="flex flex-col">
{linkBlock2.map(({ text, link }, i) => (
<a
key={i}
href={link}
target="_blank"
rel="noopener noreferrer"
className="text-secondary-foreground mb-0 flex items-center gap-2 font-mono text-xs hover:text-white"
>
<span className="text-md">¬</span>
<span>{text}</span>
</a>
))}
<div className="border-y py-10">
<div className="max-w-5xl">
Copy link
Contributor

@vercel vercel bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div className="max-w-5xl">
<div className="mx-auto max-w-5xl">

The max-w-5xl container is missing mx-auto to center it horizontally, causing the footer content to be left-aligned instead of centered.

View Details

Analysis

Footer container missing mx-auto centering class

What fails: FooterSection component at line 49 has max-w-5xl without mx-auto, causing left-alignment instead of centering on screens wider than 1024px

How to reproduce:

# View footer on wide screen (>1024px):
pnpm dev --port 3001
# Navigate to any page and scroll to footer

Result: Footer content appears left-aligned on wide screens, creating asymmetrical layout

Expected: Footer should be centered horizontally, matching established pattern used in layout.tsx (mx-auto max-w-screen-lg), chart/page.tsx (mx-auto max-w-7xl), and navbar (mx-auto max-w-screen-lg)

Reference: Tailwind CSS max-width docs confirm max-width utilities require mx-auto for centering

Copy link
Collaborator Author

@timothyylim timothyylim Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional to conform to the design

<div className="xs:grid-cols-5 grid grid-cols-3 content-center gap-8 font-normal">
<Image
src="/logo_white.svg"
alt="recallnet"
height={72}
width={63}
className="h-[72px] w-[63px]"
/>
<div className="flex flex-col">
{linkBlock1.map(({ text, link }, i) => (
<a
key={i}
href={link}
target="_blank"
rel="noopener noreferrer"
className="text-secondary-foreground mb-0 flex items-center gap-2 font-mono text-xs hover:text-white"
>
<span className="text-md">¬</span>
<span>{text}</span>
</a>
))}
</div>
<div className="flex flex-col">
{linkBlock2.map(({ text, link }, i) => (
<a
key={i}
href={link}
target="_blank"
rel="noopener noreferrer"
className="text-secondary-foreground mb-0 flex items-center gap-2 font-mono text-xs hover:text-white"
>
<span className="text-md">¬</span>
<span>{text}</span>
</a>
))}
</div>
</div>
</div>
</div>
<span className="text-secondary-foreground block py-4 text-center text-xs">
Expand Down