-
Notifications
You must be signed in to change notification settings - Fork 7
Added required changes for log messages #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Girishbari
wants to merge
5
commits into
reclaimprotocol:main
Choose a base branch
from
Girishbari:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−57
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bc496d0
Improving logging message types and error messages
Girishbari 9f8a4e1
refator import to getIdentifierFromClaimInfo from getIdentifierFromCl…
Girishbari 69ceacc
Added required changes for log meesages
Girishbari a54c2d3
Merge branch 'main' of https://github.com/Girishbari/reclaim-js-sdk
Girishbari 5e89b4d
remove unnecessary changes
Girishbari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,22 @@ | ||
// Define the possible log levels | ||
export type LogLevel = 'info' | 'warn' | 'error' | 'silent'; | ||
export type LogLevel = 'info' | 'warn' | 'error' ; | ||
export type ExtendedLog = LogLevel | 'all' | ||
|
||
// Define a simple logger class | ||
class SimpleLogger { | ||
private level: LogLevel = 'info'; | ||
private level: ExtendedLog = 'info'; | ||
|
||
setLevel(level: LogLevel) { | ||
setLevel(level: LogLevel | 'all') { | ||
this.level = level; | ||
} | ||
|
||
private shouldLog(messageLevel: LogLevel): boolean { | ||
const levels: LogLevel[] = ['error', 'warn', 'info', 'silent']; | ||
const levels: ExtendedLog[] = ['error', 'warn', 'info', 'all']; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will this log all there types of log 'error', 'warn', 'info' when logLevel is set to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didnt get your question |
||
return levels.indexOf(this.level) >= levels.indexOf(messageLevel); | ||
} | ||
|
||
private log(level: LogLevel, message: string, ...args: any[]) { | ||
if (this.shouldLog(level) && this.level !== 'silent') { | ||
if (this.shouldLog(level)) { | ||
const logFunction = this.getLogFunction(level); | ||
console.log('current level', this.level); | ||
logFunction(`[${level.toUpperCase()}]`, message, ...args); | ||
|
@@ -31,7 +32,11 @@ class SimpleLogger { | |
case 'info': | ||
return console.info; | ||
default: | ||
return () => {}; // No-op for 'silent' | ||
return (message: string, ...optionalParams: any[]) => { | ||
console.info('info',message, ...optionalParams); | ||
console.warn('warn',message, ...optionalParams); | ||
console.error('error',message, ...optionalParams); | ||
}; | ||
} | ||
} | ||
|
||
|
@@ -52,7 +57,7 @@ class SimpleLogger { | |
const logger = new SimpleLogger(); | ||
|
||
// Function to set the log level | ||
export function setLogLevel(level: LogLevel) { | ||
export function setLogLevel(level: LogLevel | 'all') { | ||
logger.setLevel(level); | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This info log should be not be in the catch block. Better to move it at top inside the try block