Move untranslatable strings to seperate file #2273
Conversation
This could cause crashes or poisoned data on some languages as some untranslatable strings were being translated, including keys and format strings that shouldn't be translatable. Also when translating the episodes key on weblate it caused a conflict between the plural version (which weblate does support) and the actual episodes key, meaning the episodes key was translating as the singular version of the plural episodes version in some cases. Moving to a separate resource file should hopefully prevent these issues.
|
Just for the record I confirmed some language like Arabic has fully translated keys and thus when switching to Arabic the data is lost and not saved between languages. That happens with a few keys in a few languages. The auto rotate and rotate button keys are present in numerous languages most notably. Also I confirmed a few wrongly formatted translated keys that shouldn't be do in fact cause the app to fully crash in safe mode in some languages. This should prevent the issues because by using This PR keeps all keys that were present before, but in the future I will also do a PR to remove the unused ones. This also removes |
|
#2257 should probably be merged and this rebased (if necessary) and merged immediately after to prevent potential conflicts with weblate as well. |
|
@fire-light42 could this perhaps be merged now if your able, to prevent further conflicts with weblate? |
|
Thank you for the contribution! I am sorry for the excessive delay. |
No problem at all. Thanks for merging! |
2 participants
This could cause crashes or poisoned data on some languages as some untranslatable strings were being translated, including keys and format strings that shouldn't be translatable. Also when translating the episodes key on weblate it caused a conflict between the plural version (which weblate does support) and the actual episodes key, meaning the episodes key was translating as the singular version of the plural episodes version in some cases. Moving to a separate resource file should hopefully prevent these issues.