Add linting to library #2301
Merged
Add linting to library #2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explicitly adds the `com.android.lint` plugin as well, but doesn't apply it in the library project, which means it does absolutely nothing right now. It was only added to simplify migration to new `com.android.kotlin.multiplatform.library`, which does require this explicitly or it won't be applied at all. When using that plugin alongside the android lint plugin, it also can apply linting to JVM and other KMP targets, which currently it can not do. In addition to that, this setups linting, fixing existing issues, and applying some basic rules in a `lint.xml` file. By doing it like this (alongside what we do for the app module already), this will eventually allow us to `failOnError`, and setup our own custom declarations for what should fail a build and better apply it when making pull requests for example (plus would be testable and ensured it already passes when build passes locally). It would allow us to better ensure we follow proper API support for example by failing if using an API not available on the `minSdk` without conditionals (the `NewAPI` lint) would help to better validate backward compatibility to the `minSdk` as well. It could also ensure certain code standards beyond just what was mentioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing it like this (alongside what we do for the app module already), this will eventually allow us to
abortOnError, and setup our own custom declarations for what should fail a build and better apply it when making pull requests for example (plus would be testable and ensured it already passes when build passes locally).It would allow us to better ensure we follow proper API support for example by failing if using an API not available on the
minSdkwithout conditionals (theNewAPIlint) would help to better validate backward compatibility to theminSdkas well.It could also ensure certain code standards beyond just what was mentioned.