-
Notifications
You must be signed in to change notification settings - Fork 747
Youtube Extractor now plays videos up to 1080p #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube Extractor now plays videos up to 1080p #2386
Conversation
Previously I had it configured that way, so trailer videos often played at low quality. I’ve therefore adjusted it to use the logic in the code so it automatically detects the available quality options and selects the highest one available for trailers. |
I understand, thank you very much anyway. |
library/src/commonMain/kotlin/com/lagradost/cloudstream3/extractors/YoutubeExtractor.kt
Outdated
Show resolved
Hide resolved
library/src/commonMain/kotlin/com/lagradost/cloudstream3/extractors/YoutubeExtractor.kt
Outdated
Show resolved
Hide resolved
fire-light42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested, so a more detailed review may come at a later time.
library/src/commonMain/kotlin/com/lagradost/cloudstream3/extractors/YoutubeExtractor.kt
Outdated
Show resolved
Hide resolved
| it.content ?: return@mapNotNull null | ||
| ) | ||
| }?.forEach(subtitleCallback) | ||
| val lines = getHls.lines() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this? We have a built in m3u8 extractor called M3u8Helper https://github.com/recloudstream/cloudstream/blob/master/library/src/commonMain/kotlin/com/lagradost/cloudstream3/utils/M3u8Helper.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to HlsPlaylistParser instead of manual parsing, as I couldn’t achieve the same result using M3u8Helper.



Trailers now play in 1080P
