[FIX]: #1070 Terms of Service Documentation Update #1081
Conversation
|
@kanishka-commits is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
github-actions
bot
added
hacktoberfest-accepted
recode
|
✅ Synchronized metadata from Issue #1070:
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| {/* New Icon Container */} | ||
| <div className={styles.iconContainer}> | ||
| <span | ||
| className={`${styles.icon} ${styles.iconPlus} ${ |
There was a problem hiding this comment.
The code references styles.iconPlus which doesn't exist in the CSS Module, causing undefined to appear in the className string when rendering the plus icon.
View Details
📝 Patch Details
diff --git a/src/pages/terms-service/index.module.css b/src/pages/terms-service/index.module.css
index 1d62eb3..025a042 100644
--- a/src/pages/terms-service/index.module.css
+++ b/src/pages/terms-service/index.module.css
@@ -178,6 +178,10 @@
top: -1px;
}
+.iconPlus {
+ position: relative;
+}
+
.iconVisible {
opacity: 1;
transform: rotate(0deg);
Analysis
Missing iconPlus CSS class causing "undefined" in className
What fails: styles.iconPlus resolves to undefined in src/pages/terms-service/index.tsx line 34, causing literal "undefined" string to appear in HTML class attributes
How to reproduce:
npm run build
grep -o 'class="[^"]*undefined[^"]*"' build/terms-service/index.htmlResult: HTML contains class="icon_H6bD undefined iconVisible_SHns">+</span> where "undefined" appears as a CSS class name
Expected: Should have proper CSS class name or remove the undefined reference. CSS module defines .iconMinus but missing corresponding .iconPlus class definition in index.module.css
The fix requires either adding .iconPlus class definition to the CSS module or removing the undefined reference from the JSX template literal.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@kanishka-commits the design was super cool., thanks for thinking outside the box designs. |
|
@sanjay-kv |
2 participants
Description
This PR completely redesigns the "Terms of Service" page (
index.tsx) to be more aesthetically pleasing and modern. The motivation was to move away from a standard "wall of text" and create an interactive, "Soft UI" (neumorphic) component that feels cohesive with the website's overall theme.This update also significantly improves the content of the ToS by:
Fixes #1070
Type of Change
Changes Made
index.module.cssto house all styling for the page, replacing previous utility classes.▼arrow with a+/−icon set within its own circular container.enhanced-footer.css.Screen.Recording.2025-10-26.at.4.43.02.PM.mp4
Dependencies
index.module.css) and modifies an existing component (index.tsx).Checklist
npm run buildand attached screenshot(s) in this PR.