fixed faqs unreadable parts #414
Conversation
|
@Adez017 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
CC: @iitzIrFan @sanjay-kv |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a text readability issue in the FAQ component where highlighted/strong text was difficult to read due to poor color contrast. The change improves the visual accessibility of FAQ answers by adjusting the text colors for better readability.
- Updates text colors for strong/bold elements in FAQ answers
- Improves contrast for both light and dark themes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/components/faqs/faqs.tsx
Outdated
| dark:[&_a]:text-indigo-400 dark:[&_a]:hover:text-indigo-300 | ||
| [&_strong]:font-semibold [&_strong]:text-gray-800 | ||
| dark:[&_strong]:text-gray-200`} | ||
| [&_strong]:font-semibold [&_strong]:text-gray-500 |
There was a problem hiding this comment.
The new gray-500 color for strong text in light mode may have insufficient contrast against a light background. Consider using a darker color like gray-700 or gray-800 to ensure WCAG accessibility standards are met.
| [&_strong]:font-semibold [&_strong]:text-gray-500 | |
| [&_strong]:font-semibold [&_strong]:text-gray-800 |
Copilot uses AI. Check for mistakes.
src/components/faqs/faqs.tsx
Outdated
| [&_strong]:font-semibold [&_strong]:text-gray-800 | ||
| dark:[&_strong]:text-gray-200`} | ||
| [&_strong]:font-semibold [&_strong]:text-gray-500 | ||
| dark:[&_strong]:text-gray-600`} |
There was a problem hiding this comment.
The gray-600 color for strong text in dark mode may not provide adequate contrast against a dark background. Consider using a lighter color like gray-300 or gray-200 to ensure proper readability in dark theme.
| dark:[&_strong]:text-gray-600`} | |
| dark:[&_strong]:text-gray-300`} |
Copilot uses AI. Check for mistakes.
|
Can you please make it work for both dark & light themes as it has an issue here, rest is good :) 
|
|
how about now ? @iitzIrFan @sanjay-kv |
|
@Adez017 You can update your pr for final review. Thanks for those changes ! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
could you add level 3 here for previous unmerged PRs @sanjay-kv |
3 participants
Description
Now we can able to read the text of highlighted part in FAQ
Fixes #407
Type of Change
Changes Made
Updated faq.tsx
Dependencies
Checklist
npm run buildand attached scrrenshot in this PR.Before :
After :