Skip to content

Conversation

iitzIrFan
Copy link
Member

@iitzIrFan iitzIrFan commented Sep 14, 2025

Description

Updated the LiveActivity Toaster and Blog Layout to show headings in the initial window.

Fixes #502

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Dependencies

  • No new dependencies added.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers/devices
  • My changes do not generate new console warnings or errors , I ran npm run build and attached scrrenshot in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

Video Implementation: Link

@iitzIrFan iitzIrFan self-assigned this Sep 14, 2025
@iitzIrFan iitzIrFan added the enhancement New feature or request label Sep 14, 2025
Copy link

vercel bot commented Sep 14, 2025

Someone is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@iitzIrFan iitzIrFan moved this to In Progress in @recode-web Sep 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug with the LiveActivity Toaster and Blog Layout to ensure headings are properly displayed in the initial window. The changes primarily focus on improving the visual appearance and consistency of the FloatingContributors component.

  • Standardized message length limits to 50 characters throughout the component for consistency
  • Updated styling with a more cohesive color scheme and improved visual hierarchy
  • Fixed sizing and layout issues to ensure proper display of content within the toaster window

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/components/blogCarousel/blogCarousel.css Reduced padding to fix spacing issues in the blog carousel section
src/components/FloatingContributors/index.tsx Standardized message lengths and updated action text styling for consistency
src/components/FloatingContributors/FloatingContributors.css Comprehensive styling updates including color scheme, sizing, and layout improvements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

.blog-carousel-section {
background: linear-gradient(135deg, #f8f9ff 0%, #f0f2ff 50%, #e8ebff 100%);
padding: 60px 0;
padding: 5px;
Copy link

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The padding has been drastically reduced from '60px 0' to '5px'. This significant change may cause layout issues or insufficient spacing. Consider using a more moderate value like '30px 0' or '20px 0' to maintain proper visual hierarchy.

Suggested change
padding: 5px;
padding: 30px 0;

Copilot uses AI. Check for mistakes.

<div className="activity-user">
<span className="activity-username">@{currentActivity.contributor.login}</span>
<span className="activity-username" title={`@${currentActivity.contributor.login}`}>@{currentActivity.contributor.login}</span>
<span className="activity-action-badge">
Copy link

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action icon has been removed from the activity action badge display, but the getActionIcon function is still defined in the component. This creates inconsistency and may leave users without visual context for the action type.

Suggested change
<span className="activity-action-badge">
<span className="activity-action-badge">
<span className="activity-action-icon" aria-hidden="true" style={{ marginRight: 4 }}>
{getActionIcon(currentActivity.action)}
</span>

Copilot uses AI. Check for mistakes.

}

.floating-contributors-container.header-embedded .floating-contributors-card {
min-width: 500px;
Copy link

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The padding property has been removed from this media query rule, but min-width is still being overridden. This inconsistency may cause layout issues on larger screens. Either remove the entire rule or include appropriate padding values.

Suggested change
min-width: 500px;
min-width: 500px;
padding: 28px;

Copilot uses AI. Check for mistakes.

Copy link

vercel bot commented Sep 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Sep 15, 2025 0:10am

@sanjay-kv sanjay-kv merged commit 5235637 into recodehive:main Sep 15, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: change the size of toaster

2 participants