-
Notifications
You must be signed in to change notification settings - Fork 121
Bug/toaster #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/toaster #506
Conversation
Someone is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug with the LiveActivity Toaster and Blog Layout to ensure headings are properly displayed in the initial window. The changes primarily focus on improving the visual appearance and consistency of the FloatingContributors component.
- Standardized message length limits to 50 characters throughout the component for consistency
- Updated styling with a more cohesive color scheme and improved visual hierarchy
- Fixed sizing and layout issues to ensure proper display of content within the toaster window
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
src/components/blogCarousel/blogCarousel.css | Reduced padding to fix spacing issues in the blog carousel section |
src/components/FloatingContributors/index.tsx | Standardized message lengths and updated action text styling for consistency |
src/components/FloatingContributors/FloatingContributors.css | Comprehensive styling updates including color scheme, sizing, and layout improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.blog-carousel-section { | ||
background: linear-gradient(135deg, #f8f9ff 0%, #f0f2ff 50%, #e8ebff 100%); | ||
padding: 60px 0; | ||
padding: 5px; |
Copilot
AI
Sep 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The padding has been drastically reduced from '60px 0' to '5px'. This significant change may cause layout issues or insufficient spacing. Consider using a more moderate value like '30px 0' or '20px 0' to maintain proper visual hierarchy.
padding: 5px; | |
padding: 30px 0; |
Copilot uses AI. Check for mistakes.
<div className="activity-user"> | ||
<span className="activity-username">@{currentActivity.contributor.login}</span> | ||
<span className="activity-username" title={`@${currentActivity.contributor.login}`}>@{currentActivity.contributor.login}</span> | ||
<span className="activity-action-badge"> |
Copilot
AI
Sep 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The action icon has been removed from the activity action badge display, but the getActionIcon
function is still defined in the component. This creates inconsistency and may leave users without visual context for the action type.
<span className="activity-action-badge"> | |
<span className="activity-action-badge"> | |
<span className="activity-action-icon" aria-hidden="true" style={{ marginRight: 4 }}> | |
{getActionIcon(currentActivity.action)} | |
</span> |
Copilot uses AI. Check for mistakes.
} | ||
|
||
.floating-contributors-container.header-embedded .floating-contributors-card { | ||
min-width: 500px; |
Copilot
AI
Sep 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The padding property has been removed from this media query rule, but min-width is still being overridden. This inconsistency may cause layout issues on larger screens. Either remove the entire rule or include appropriate padding values.
min-width: 500px; | |
min-width: 500px; | |
padding: 28px; |
Copilot uses AI. Check for mistakes.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
Updated the LiveActivity Toaster and Blog Layout to show headings in the initial window.
Fixes #502
Type of Change
Dependencies
Checklist
npm run build
and attached scrrenshot in this PR.Video Implementation: Link