Skip to content

Conversation

Codeboy20
Copy link
Contributor

Description

This PR addresses two critical UI/UX issues to improve the user experience on the Terms of Service page, particularly for users with dark mode enabled.

This pr fixes #557

The issues fixed are:

Poor Contrast in Dark Mode: The highlighted text ("recodehive" and "Sanjay Viswanathan") was difficult to read in dark mode due to poor color contrast. This fix adjusts the background and text color specifically for dark mode to ensure readability.

Unintended Spacing: Unnecessary whitespace and line breaks in the JSX code were creating unwanted gaps between words, disrupting the text's flow and appearance.

By resolving these issues, the Terms of Service page is now more accessible and visually consistent across both light and dark themes.

Type of Change

[ ] New feature

[x] Bug fix

[x] UI/UX improvement

[ ] Performance optimization

[ ] Documentation update

Changes Made

Color Visibility in Dark Mode: Modified the and tags to include Tailwind's dark: utility classes.

bg-yellow-100 was changed to bg-yellow-100 dark:bg-yellow-600 to provide a darker, more contrasting background in dark mode.

dark:text-gray-900 was added to ensure the text remains dark and highly legible on the darker background.

Spacing Fix: The line breaks and extra spaces surrounding the and tags were removed from the JSX. This change prevents React from rendering unintended spaces and restores the proper word spacing.

Checklist

[x] My code follows the style guidelines of this project.

[x] I have tested my changes across major browsers and devices.

[x] My changes do not generate any new console warnings or errors.

[x] I ran npm run build and have attached relevant screenshots.

[x] This PR is for an issue that was assigned to me.

Screenshot -

image image

Copy link

vercel bot commented Sep 21, 2025

@Codeboy20 is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Codeboy20
Copy link
Contributor Author

Hi , @sanjay-kv Done with the changes , you can review them

Copy link

vercel bot commented Sep 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Sep 21, 2025 2:13pm

@sanjay-kv sanjay-kv moved this to In Progress in @recode-web Sep 21, 2025
@sanjay-kv sanjay-kv added this to the recode:launch 3.0 milestone Sep 21, 2025
@sanjay-kv sanjay-kv merged commit 4142ea3 into recodehive:main Sep 21, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fix Highlight/Background Color Overlapping Text on Terms of Service Page

2 participants