Skip to content

Conversation

Adez017
Copy link
Member

@Adez017 Adez017 commented Sep 22, 2025

Description

Fixes #532

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

Dependencies

  • List any new dependencies or tools required for this change.
  • Mention any version updates or configurations that need to be considered.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

Copilot AI and others added 4 commits September 22, 2025 10:35
Add clickable PR list modal to leaderboard for viewing contributor pull requests
@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 16:08
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

vercel bot commented Sep 22, 2025

@Adez017 is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds PR details functionality to the leaderboard by implementing a modal that displays detailed information about contributors' merged pull requests.

  • Added PR details tracking to contributors with title, URL, merge date, repository name, and PR number
  • Created a modal component to display a list of individual PRs when users click on PR badges
  • Implemented fallback mock data functionality for testing and error handling scenarios

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/lib/statsProvider.tsx Extended data models and API processing to capture detailed PR information
src/components/dashboard/LeaderBoard/mockData.ts Added mock contributor data with PR details for testing purposes
src/components/dashboard/LeaderBoard/leaderboard.tsx Integrated modal functionality and clickable PR badges with fallback data handling
src/components/dashboard/LeaderBoard/leaderboard.css Added comprehensive styling for the PR modal component
src/components/dashboard/LeaderBoard/PRListModal.tsx New modal component for displaying detailed PR information

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

};
merged_at?: string | null;
title?: string;
html_url?: string;
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These optional properties in PullRequestItem interface duplicate existing properties. The interface already has html_url on line 64, and these additions create redundancy. Consider consolidating or clarifying the purpose of these duplicate fields.

Suggested change
html_url?: string;
pr_url?: string;

Copilot uses AI. Check for mistakes.


// Add detailed PR information
if (pr.title && pr.html_url && pr.merged_at && pr.number) {
contributor.prDetails = contributor.prDetails || [];
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prDetails array is already initialized on line 223 when creating a new contributor, making the null check on line 232 redundant. Consider removing this redundant initialization.

Suggested change
contributor.prDetails = contributor.prDetails || [];

Copilot uses AI. Check for mistakes.

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 16:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

// Use mock data only in development mode when there's an error or no contributors
const displayContributors =
(error || contributors.length === 0)
? (typeof process !== "undefined" && process.env.NODE_ENV === "development"
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typeof process !== "undefined" check is unnecessary in a React/Node.js environment where process is always available. This check is typically used for browser environments, but here you're already checking process.env.NODE_ENV. Simplify to just check the environment directly.

Suggested change
? (typeof process !== "undefined" && process.env.NODE_ENV === "development"
? (process.env.NODE_ENV === "development"

Copilot uses AI. Check for mistakes.

Comment on lines +398 to +410
{error && (
<div className="error-banner" style={{
padding: '12px',
backgroundColor: isDark ? '#fee8e7' : '#fee8e7',
color: '#dc2626',
borderRadius: '8px',
marginBottom: '16px',
fontSize: '14px',
textAlign: 'center'
}}>
Demo Mode: Showing sample data due to API configuration issue
</div>
)}
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backgroundColor is the same for both dark and light modes (#fee8e7). This will likely cause poor contrast in dark mode. The background should be different for dark mode, such as #991b1b or another dark-appropriate color.

Copilot uses AI. Check for mistakes.

@Adez017
Copy link
Member Author

Adez017 commented Sep 22, 2025

@sanjay-kv sanjay-kv moved this to In Progress in @recode-web Sep 23, 2025
@sanjay-kv sanjay-kv removed the status in @recode-web Sep 23, 2025
@sanjay-kv sanjay-kv added this to the recode:launch 3.0 milestone Sep 23, 2025
Copy link

vercel bot commented Sep 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Sep 24, 2025 9:56am

@Adez017
Copy link
Member Author

Adez017 commented Sep 23, 2025

@sanjay-kv wait for now , don't merge it , i need to sync with @iitzIrFan changes

@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 12:32
@Adez017
Copy link
Member Author

Adez017 commented Sep 23, 2025

Now ready to go @sanjay-kv , also @iitzIrFan , kindly review as of my end i test the filter also you created and its working but to be more sure you can test also

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings September 23, 2025 12:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@iitzIrFan iitzIrFan moved this to In Progress in @recode-web Sep 23, 2025
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's amazingly done @Adez017 Thanks for this feature and yeah it is working with the filtering.
@sanjay-kv Ready for merge.

@iitzIrFan iitzIrFan added Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. under review Review under the maintainers or the admins and removed under review Review under the maintainers or the admins labels Sep 23, 2025
@sanjay-kv
Copy link
Member

sanjay-kv commented Sep 24, 2025

Love the collaboration here @iitzIrFan @Adez017

@sanjay-kv sanjay-kv merged commit a2401eb into recodehive:main Sep 24, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Sep 24, 2025
@Adez017
Copy link
Member Author

Adez017 commented Sep 24, 2025

Hi @sanjay-kv , add the gssoc related labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc25 level 2 30 points Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Add the PR's to the leaderboard

3 participants