-
Notifications
You must be signed in to change notification settings - Fork 138
fix: enable dark mode support on Courses page #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable dark mode support on Courses page #591
Conversation
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
Someone is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
iitzIrFan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! @kalyaniugale Thanks for the video preview of your implementation.
@sanjay-kv Ready for merge.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
This PR fixes the issue where the Courses page did not properly respond to the dark mode toggle in the navbar.
By defining the correct CSS variables for
[data-theme='dark'], the page now automatically adapts when the theme is switched.Fixes #581
Type of Change
Changes Made
courses.cssdark theme block to include proper values for:--courses-bg-primary,--courses-bg-secondary,--courses-bg-tertiary)--courses-text-primary,--courses-text-secondary,--courses-text-muted)--courses-border,--courses-shadow, etc.)--dark-*variables.var(--courses-*)references in components now switch styles correctly with the navbar toggle.Dependencies
Checklist
npm run buildsuccessfully and verified the Courses page works in both dark and light mode.before :
Recording.2025-09-23.191943.mp4
after :
Recording.2025-09-23.192024.mp4