Skip to content

Conversation

kalyaniugale
Copy link

@kalyaniugale kalyaniugale commented Sep 23, 2025

Description

This PR fixes the issue where the Courses page did not properly respond to the dark mode toggle in the navbar.
By defining the correct CSS variables for [data-theme='dark'], the page now automatically adapts when the theme is switched.

Fixes #581

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Changes Made

  • Updated courses.css dark theme block to include proper values for:
    • Background colors (--courses-bg-primary, --courses-bg-secondary, --courses-bg-tertiary)
    • Text colors (--courses-text-primary, --courses-text-secondary, --courses-text-muted)
    • Borders & shadows (--courses-border, --courses-shadow, etc.)
  • Removed references to undefined --dark-* variables.
  • Verified that existing var(--courses-*) references in components now switch styles correctly with the navbar toggle.

Dependencies

  • No new dependencies added.
  • No config changes required.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices.
  • My changes do not generate new console warnings or errors.
  • I ran npm run build successfully and verified the Courses page works in both dark and light mode.
  • This issue was assigned to me before raising the PR.

before :

Recording.2025-09-23.191943.mp4

after :

Recording.2025-09-23.192024.mp4

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

vercel bot commented Sep 23, 2025

Someone is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@iitzIrFan iitzIrFan added the kind:bug This is a clearly a bug label Sep 23, 2025
@iitzIrFan iitzIrFan moved this to In Progress in @recode-web Sep 23, 2025
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! @kalyaniugale Thanks for the video preview of your implementation.
@sanjay-kv Ready for merge.

@iitzIrFan iitzIrFan added Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. under review Review under the maintainers or the admins and removed under review Review under the maintainers or the admins labels Sep 23, 2025
Copy link

vercel bot commented Sep 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Sep 24, 2025 10:10am

@sanjay-kv sanjay-kv merged commit b2e3c46 into recodehive:main Sep 24, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc25 kind:bug This is a clearly a bug level 2 30 points Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Dark Mode is Not applying on courses Page

3 participants