-
Notifications
You must be signed in to change notification settings - Fork 118
add share functionality #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add share functionality #595
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds share functionality to the podcasts page, allowing users to share podcast links through the native Web Share API or clipboard fallback.
- Implements a new
handleShare
function that utilizes the Web Share API when available - Adds click event handling to the existing share button to trigger the sharing functionality
- Provides clipboard fallback for browsers that don't support the Web Share API
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
} catch (err) { | ||
// Fallback to clipboard | ||
navigator.clipboard.writeText(podcast.spotifyUrl); | ||
} |
Copilot
AI
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clipboard fallback in the catch block should handle potential clipboard API failures. The clipboard.writeText() method can also throw errors if clipboard access is denied or unavailable.
Copilot uses AI. Check for mistakes.
} else { | ||
navigator.clipboard.writeText(podcast.spotifyUrl); | ||
} |
Copilot
AI
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clipboard operation should be wrapped in a try-catch block to handle cases where clipboard access is denied or the API is unavailable.
Copilot uses AI. Check for mistakes.
@Shitanshukumar607 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
3a2e6b4
to
378066d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
navigator.clipboard.writeText(podcast.spotifyUrl); | ||
} | ||
} else { | ||
navigator.clipboard.writeText(podcast.spotifyUrl); |
Copilot
AI
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catch block silently handles errors without informing the user. Consider adding user feedback (e.g., toast notification) when the Web Share API fails and fallback to clipboard is used, or when clipboard operations fail.
navigator.clipboard.writeText(podcast.spotifyUrl); | |
} | |
} else { | |
navigator.clipboard.writeText(podcast.spotifyUrl); | |
try { | |
await navigator.clipboard.writeText(podcast.spotifyUrl); | |
alert('Sharing failed. Link copied to clipboard instead.'); | |
} catch (clipboardErr) { | |
alert('Sharing failed and copying to clipboard also failed.'); | |
} | |
} | |
} else { | |
try { | |
await navigator.clipboard.writeText(podcast.spotifyUrl); | |
alert('Link copied to clipboard.'); | |
} catch (clipboardErr) { | |
alert('Copying to clipboard failed.'); | |
} |
Copilot uses AI. Check for mistakes.
navigator.clipboard.writeText(podcast.spotifyUrl); | ||
} | ||
} else { | ||
navigator.clipboard.writeText(podcast.spotifyUrl); |
Copilot
AI
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clipboard operation lacks error handling. The writeText
method can fail (e.g., when clipboard permissions are denied) and should be wrapped in a try-catch block with appropriate user feedback.
navigator.clipboard.writeText(podcast.spotifyUrl); | |
} | |
} else { | |
navigator.clipboard.writeText(podcast.spotifyUrl); | |
try { | |
await navigator.clipboard.writeText(podcast.spotifyUrl); | |
alert('Podcast link copied to clipboard!'); | |
} catch (clipboardErr) { | |
alert('Failed to copy podcast link to clipboard.'); | |
} | |
} | |
} else { | |
try { | |
await navigator.clipboard.writeText(podcast.spotifyUrl); | |
alert('Podcast link copied to clipboard!'); | |
} catch (clipboardErr) { | |
alert('Failed to copy podcast link to clipboard.'); | |
} |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! @Shitanshukumar607 Thanks for PR :)
@sanjay-kv Ready for merge.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
Add share functioanlity in
/podcasts
Fixes #588
Type of Change
Changes Made
Dependencies
Checklist
npm run build
and attached screenshot(s) in this PR.