Added light theme for contact us page #617
Conversation
Co-Authored-By: Sanjay Viswanathan <[email protected]>
|
@Adez017 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
@sanjay-kv , take a look |
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive light theme support for the contact us page by implementing a complete styling overhaul with theme-aware CSS variables and removing form validation logic.
- Replaced inline Tailwind classes with custom CSS using CSS variables for theme support
- Removed client-side form validation and state management logic
- Added comprehensive light/dark theme styling with animations and responsive design
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pages/contact-us/index.tsx | Simplified component by removing form state management and replacing Tailwind classes with semantic CSS classes |
| src/pages/contact-us/index.css | Added comprehensive CSS with theme-aware variables, animations, and responsive design for both light and dark themes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -1,165 +1,81 @@ | |||
| import React, { useState } from "react"; | |||
| import React from "react"; | |||
There was a problem hiding this comment.
The useState import was removed but all form state management and validation logic was also removed. This creates a non-functional form that cannot handle user input or provide feedback. Consider keeping basic form functionality or adding a note that this is intentionally non-functional.
Copilot uses AI. Check for mistakes.
| <div className="grid md:grid-cols-2 gap-4"> | ||
| <div> | ||
| <label htmlFor="firstName" className="block text-sm font-medium mb-2" style={{color: 'white'}}> | ||
| <form className="contact-form"> |
There was a problem hiding this comment.
The form has no onSubmit handler and will cause a page reload when submitted. Add an onSubmit handler to prevent default behavior and handle form submission properly.
Copilot uses AI. Check for mistakes.
|
@sanjay-kv , don't merge it now , i need to fix some things |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 participants
Description
Fixes #436
Type of Change
Changes Made
Dependencies
Checklist
npm run buildand attached screenshot(s) in this PR.Screenshots