Skip to content

Conversation

ishubtripathi
Copy link

Description

This PR fixes visual inconsistencies in blog cards and updates their styling for better layout, consistency, and a polished look.

  • Fixed card sizing to ensure all blog cards have equal width and height.
  • Refactored the BlogCard component to use CSS-only hover effects for smooth, responsive interactions.
  • Moved inline JavaScript hover logic into blogs-new.css for easier maintenance and quicker feedback.
  • Improved the layout of the cards, image scaling, overlay.
  • Made sure the cards respond well on different devices.

Fixes # (issue)

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (change that fixes an issue without breaking anything)
  • UI/UX improvement (updates to design, layout, or styling)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

  • Set fixed width and height for .fixed-card-size to standardize card sizes.
  • Applied flex layout to .article-card and its children for consistent alignment.
  • Restricted titles and descriptions to fixed lines to prevent uneven card heights.
  • Replaced inline JavaScript hover logic with CSS-only transitions.
  • Used semantic, BEM-style class naming for easier maintenance.
  • Improved overlay and button styling for better accessibility and responsiveness.

Dependencies

  • No new dependencies added.
  • No version updates needed.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices.
  • My changes do not create new console warnings or errors.
  • I ran npm run build and attached a screenshot in this PR.
  • This issue is assigned to me, not an unassigned one.

- Set fixed width and height for .fixed-card-size in blogs-new.css
- Used flexbox and line clamping for consistent card layout
- Updated BlogCard component to use line-clamp classes for title and description
- Now all cards remain visually equal regardless of content length
…onal appearance

- Updated BlogCard component to use semantic, BEM-style class names and removed all inline styles and JS hover logic
- Moved all card styling and hover/scale transitions to blogs.css for instant, smooth feedback
- Improved card layout, image scaling, overlay, and Read Article button styling for a modern, accessible look
- Ensured responsive design and consistent appearance across devices
Copy link

vercel bot commented Oct 2, 2025

@ishubtripathi is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 2, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added level 1 10 points recode this is label for leaderboard labels Oct 2, 2025
@Adez017 Adez017 requested review from sanjay-kv and Adez017 October 2, 2025 10:33
@Adez017
Copy link
Member

Adez017 commented Oct 2, 2025

Hi @ishubtripathi , could you add a video about of how the changes working for a better review process.

Copy link
Member

@Adez017 Adez017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request for video for the changes and also the linked or assigned issue.
@sanjay-kv @ishubtripathi

@ishubtripathi
Copy link
Author

After changes, the result looks something like this @sanjay-kv @Adez017

Contribution.mp4

@Adez017
Copy link
Member

Adez017 commented Oct 2, 2025

@ishubtripathi , i noticed that in your chnages the latency has been fixed but if you carefully observed there is a hover effect and the cards comes up a little up but in the video that has gone , i want that instead of remove that completely you can fix that and ping me again .Also please link the issue for this

@Adez017 Adez017 self-requested a review October 2, 2025 11:58
@ishubtripathi
Copy link
Author

Okay, I'll fix it

@ishubtripathi
Copy link
Author

@Adez017 Now you can check it out, I'll add the smooth scale-up animation on the blog card while hover on it.

@Adez017
Copy link
Member

Adez017 commented Oct 2, 2025

@Adez017 Now you can check it out, I'll add the smooth scale-up animation on the blog card while hover on it.

Shared the video @ishubtripathi

@Adez017
Copy link
Member

Adez017 commented Oct 2, 2025

Also mention the issue no.

@ishubtripathi
Copy link
Author

@Adez017 Here it is, and my issue no is #657

2025-10-02.20-23-14.mp4

Copy link
Member

@Adez017 Adez017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Adez017
Copy link
Member

Adez017 commented Oct 2, 2025

LGTM ! @ishubtripathi
@sanjay-kv ready for merge

@Adez017 Adez017 added gssoc25 level 2 30 points hacktoberfest-accepted Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. and removed level 1 10 points labels Oct 2, 2025
@ishubtripathi ishubtripathi requested a review from Adez017 October 2, 2025 15:21
Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Oct 3, 2025 2:54am

@sanjay-kv
Copy link
Member

image

There is a huge gap between the cards @ishubtripathi
need to fix this

b/w liked the before and after video

…bsite responsive for all screen size devices
@ishubtripathi
Copy link
Author

@sanjay-kv You are correct, it is showing the huge gap between cards when it is open in large screen devices, I apologize for my mistake that I did not cross check it on all types of devices, But now it is responsive for all screen size device, you can check it out.

Screenshot 2025-10-03 083904

@sanjay-kv sanjay-kv added the under review Review under the maintainers or the admins label Oct 3, 2025
@Adez017 Adez017 self-requested a review October 3, 2025 14:11
@iitzIrFan iitzIrFan added under review Review under the maintainers or the admins don't-merge faced conflict issue or other dev related issue, dont merge PR and removed under review Review under the maintainers or the admins Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. labels Oct 6, 2025
@iitzIrFan
Copy link
Member

@ishubtripathi Any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't-merge faced conflict issue or other dev related issue, dont merge PR gssoc25 hacktoberfest-accepted level 2 30 points recode this is label for leaderboard under review Review under the maintainers or the admins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants