Skip to content

Conversation

Condition00
Copy link
Contributor

@Condition00 Condition00 commented Oct 2, 2025

Description

Fixed normal spacing and removed extra "more" keyword.

Fixes # (issue)
padding and spacing issue in the Floating Card Component

Type of Change

  • [ . ] Bug fix (non-breaking change that fixes an issue)
  • [ . ] UI/UX improvement (design, layout, or styling updates)

Changes Made

Added padding gaps and spacing to the card component.

Dependencies

No new dependency.

Checklist

  • [ . ] My code follows the style guidelines of this project.
  • [ . ] I have tested my changes across major browsers and devices
  • [ . ] My changes do not generate new console warnings or errors .
  • [ . ] I ran npm run build and attached screenshot(s) in this PR.
  • [ . ] This is already assigned Issue to me, not an unassigned issue.
image image

Fixes #659

@Copilot Copilot AI review requested due to automatic review settings October 2, 2025 12:11
Copy link

vercel bot commented Oct 2, 2025

@Condition00 is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 2, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added level 1 10 points recode this is label for leaderboard labels Oct 2, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes spacing and padding issues in the Floating Card Component by improving layout consistency and removing redundant text from the contributor count display.

  • Updated contributor threshold from 12 to 5 for displaying the "more" count
  • Removed the word "more" from the contributor count text, showing only the numeric count
  • Enhanced spacing, padding, and layout properties throughout the component for better visual consistency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/components/FloatingContributors/index.tsx Updated contributor threshold and removed "more" text from count display
src/components/FloatingContributors/FloatingContributors.css Comprehensive spacing and layout improvements including padding, gaps, and height adjustments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +585 to 589
{contributors.length > 5 && (
<div className="contributors-more">
<span>+{contributors.length - 12} more</span>
<span>+{contributors.length - 5}</span>
</div>
)}
Copy link

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The magic number 5 is used twice without explanation. Consider extracting this to a named constant like CONTRIBUTORS_DISPLAY_THRESHOLD to improve maintainability and make the relationship between the condition and calculation more explicit.

Copilot uses AI. Check for mistakes.

Copy link

github-actions bot commented Oct 2, 2025

Synced data from Linked Issues

Labels:

  • gssoc25
  • level 1
  • recode
  • hacktoberfest-accepted

Assignees:

  • Condition00

Milestones:

  • recode:launch 3.0

Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Oct 3, 2025 3:17am

@sanjay-kv sanjay-kv merged commit 511b6ae into recodehive:main Oct 3, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Oct 3, 2025
@Condition00 Condition00 deleted the issue-#659 branch October 3, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted level 1 10 points recode this is label for leaderboard

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Padding and spacing issues in Floating Contributors Card

2 participants