-
Notifications
You must be signed in to change notification settings - Fork 105
fix: footer copyright alignment and Form select bg #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@dipanshurdev is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Synced data from Linked IssuesLabels:
Assignees:
Milestones:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes footer copyright alignment by removing the previous right-aligned copyright container and introducing a new centered footer block. Key adjustments include commenting out the old markup, adding new structural elements, and CSS additions (including a new generic .footer class and related styles).
- Replaced previous right-aligned copyright block with a new centered structure
- Added new .footer and .footer-content classes and adjusted layout-related CSS
- Modified/extended existing CSS selectors and widths for removed elements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/theme/Footer/Layout/index.tsx | Reworks footer copyright structure by removing old container and adding a new centered block |
src/theme/Footer/Layout/enhanced-footer.css | Adds styles for new footer structure and updates widths and layout for (now commented-out) elements |
Comments suppressed due to low confidence (1)
src/theme/Footer/Layout/enhanced-footer.css:1
- Width changes were added to .footer-bottom-right and .footer-copyright, but the corresponding markup for these elements is now commented out. Remove or revert these unused style adjustments, or restore the structure if still needed to avoid stale CSS.
/* Enhanced Footer Styles - COMPLETELY ISOLATED FROM THEME CHANGES */
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! @dipanshurdev
@sanjay-kv Ready for merge.
Description
Fixes # (issue)
#687
#753
Type of Change
Screenshot
Footer copyright
Form Select bg