-
Notifications
You must be signed in to change notification settings - Fork 105
Enhanced topmate section and fixed the inconsistencies issue#704 #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Condition00 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Synced data from Linked IssuesLabels:
Assignees:
Milestones:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the TopMate section UI and fixes inconsistencies in the testimonials carousel. The changes focus on improving responsive design, modernizing visual styling, and creating a more cohesive user experience across components.
- Redesigned TopMate card with improved responsive layout and modern styling
- Enhanced testimonial carousel with better pagination controls and consistent spacing
- Updated typography and color schemes to use purple/pink gradient themes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
src/components/topmate/TopMateSection.tsx | Added responsive padding and max-width constraints for better layout |
src/components/topmate/TopMateCard.tsx | Complete redesign with modern card styling, improved close button, and enhanced responsive behavior |
src/components/testimonials/TestimonialCarousel.tsx | Updated pagination dots with gradient styling and improved navigation controls |
src/components/testimonials/TestimonialCard.tsx | Enhanced card design with consistent purple theme and improved responsive layout |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
))} | ||
</div> | ||
{/* Gradient Overlay - Shows on Hover */} | ||
<div className="absolute inset-0 bg-gradient-to-br from-purple-500/0 via-pink-500/0 to-purple-500/0 group-hover:from-purple-500/10 group-hover:via-pink-500/10 group-hover:to-purple-500/10 transition-all duration-500 pointer-events-none hover:cursor-pointer" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hover:cursor-pointer
class is redundant with pointer-events-none
. Since pointer events are disabled, the cursor style won't be applied. Remove hover:cursor-pointer
or reconsider the pointer-events strategy.
<div className="absolute inset-0 bg-gradient-to-br from-purple-500/0 via-pink-500/0 to-purple-500/0 group-hover:from-purple-500/10 group-hover:via-pink-500/10 group-hover:to-purple-500/10 transition-all duration-500 pointer-events-none hover:cursor-pointer" /> | |
<div className="absolute inset-0 bg-gradient-to-br from-purple-500/0 via-pink-500/0 to-purple-500/0 group-hover:from-purple-500/10 group-hover:via-pink-500/10 group-hover:to-purple-500/10 transition-all duration-500 pointer-events-none" /> |
Copilot uses AI. Check for mistakes.
<CarouselPrevious className="static translate-y-0" /> | ||
<div className="flex gap-2"> | ||
<div className="flex items-center justify-center gap-4 mt-8"> | ||
<CarouselPrevious className="static translate-y-0 cursor-pointer" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Adding cursor-pointer
class to navigation buttons is redundant since buttons already have pointer cursor by default. Consider removing this class for cleaner code.
Copilot uses AI. Check for mistakes.
))} | ||
</div> | ||
<CarouselNext className="static translate-y-0" /> | ||
<CarouselNext className="static translate-y-0 cursor-pointer" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Adding cursor-pointer
class to navigation buttons is redundant since buttons already have pointer cursor by default. Consider removing this class for cleaner code.
Copilot uses AI. Check for mistakes.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
I will put this under review as this a major design change and in size. i have to get the teams opinion . will merge it soon or request some changes based on the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! @Condition00
@sanjay-kv This design is descriptive for the reviews or else we have to make it clickable.
yup yup its fine. I can make any changes if you want. @sanjay-kv |
Description
Enhanced and changed the ui of topmate section, made the ui of carousel and pagination better.
Fixes #704
Type of Change
Changes Made
Remodeled entire topmate section, fixed the pagination with better styling and removed inconsistencies.
Dependencies
No new dependencies used.
Checklist
npm run build
and attached screenshot(s) in this PR.Screen.Recording.2025-10-03.222002.mp4