-
Notifications
You must be signed in to change notification settings - Fork 114
Fixed #713 : light theme in interview prep #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@prathamesh424 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Synced data from Linked IssuesLabels:
Assignees:
Milestones:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements light theme support for the Footer and Interview Prep page components. The changes add conditional styling based on the current color mode to ensure proper appearance in both light and dark themes.
- Adds color mode detection using Docusaurus's
useColorMode
hook - Implements conditional CSS classes for theme-aware styling
- Updates color declarations to support both light and dark modes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/theme/Footer/Layout/index.tsx | Adds color mode detection and conditional theme classes to footer |
src/theme/Footer/Layout/enhanced-footer.css | Implements light theme styles and updates selector specificity |
src/styles/globals.css | Updates dark mode variant to support both class and attribute selectors |
src/pages/interview-prep/index.tsx | Adds theme-aware styling and extracts content into separate component |
src/pages/interview-prep/PracticeTab.tsx | Updates text color classes for proper light theme visibility |
src/pages/interview-prep/OverviewTab.tsx | Adds theme-aware text colors and removes problematic color classes |
src/pages/interview-prep/CompaniesTab.tsx | Updates text colors and input styling for light theme support |
src/pages/interview-prep/BehavioralTab.tsx | Adds proper theme-aware text colors |
src/css/custom.css | Implements comprehensive theme-aware styling rules and fixes color inheritance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
<li className="flex items-start"> | ||
<span className="w-2 h-2 bg-blue-500 rounded-full mr-3 mt-2 flex-shrink-0"></span> | ||
<span> | ||
<span className=""> |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty className attribute should be removed as it serves no purpose and can cause confusion.
<span className=""> | |
<span> |
Copilot uses AI. Check for mistakes.
src/css/custom.css
Outdated
[data-theme="light"] .interview-prep-page h6 { | ||
color: #ffffff !important; | ||
/* Use a dark heading color in light mode for readability */ | ||
color: #111827 !important; /* tailwind gray-900 */ |
Copilot
AI
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment mentions 'tailwind gray-900' but this should be 'Tailwind' (capitalized) for consistency with standard naming conventions.
color: #111827 !important; /* tailwind gray-900 */ | |
color: #111827 !important; /* Tailwind gray-900 */ |
Copilot uses AI. Check for mistakes.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
Added the Light theme in the Footer and the Interview Prep page
Fixes #713
Type of Change
Changes Made
In CSS for the light theme support
Dependencies
Checklist
npm run build
and attached screenshot(s) in this PR.