Skip to content

Increase button text contrast for better accessibility and readability. #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+5 −5
Closed

Increase button text contrast for better accessibility and readability. #784

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0febc42
Increase button text contrast for better accessibility and readability.
steam-bell-92 Oct 4, 2025
be53fae
reverted the version of firebase only
steam-bell-92 Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
"dotenv": "^16.6.1",
"embla-carousel-autoplay": "^8.6.0",
"embla-carousel-react": "^8.6.0",
"firebase": "^9.22.2",
"firebase": "^12.3.0",
"firebaseui": "6.1.0",
"framer-motion": "^12.7.5",
"framer-motion": "^12.23.22",
"lucide-react": "^0.503.0",
"prism-react-renderer": "^2.3.0",
"react": "^18.3.1",
Expand Down
8 changes: 4 additions & 4 deletions src/pages/interview-prep/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,14 +1205,14 @@ function InterviewPrepContent({
<motion.div className="flex flex-col sm:flex-row gap-4 justify-center" variants={fadeIn}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this was covered in some other PR's or am I missing something here @steam-bell-92

Image Image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this was covered in some other PR's or am I missing something here @steam-bell-92

Image Image

Yeah this is the same thing I covered maybe this one was merged before mine

Copy link
Member

@iitzIrFan iitzIrFan Oct 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts on this PR, you can checkout other Issues and contribute to the ones that, excites you :) @steam-bell-92

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, also I had raised an issue #785 so can I get that assigned. It's just typos correction from docs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check that out in a while ! @steam-bell-92

<Link
to="/get-started"
className="bg-white text-blue-600 px-8 py-4 rounded-lg font-semibold hover:bg-blue-50 transition-all duration-300 transform hover:scale-105 shadow-lg"
>
className="border-2 border-white bg-transparent text-white px-8 py-4 rounded-lg font-semibold hover:bg-white hover:text-blue-600 transition-all duration-300 transform hover:scale-105 shadow-lg"
>
Start Preparing Now
</Link>
<Link
to="/community"
className="border-2 border-white bg-white text-blue-500 px-8 py-4 rounded-lg font-semibold hover:bg-white hover:text-blue-600 transition-all duration-300"
>
className="border-2 border-white bg-transparent text-white px-8 py-4 rounded-lg font-semibold hover:bg-white hover:text-blue-600 transition-all duration-300"
>
Join Community
</Link>
</motion.div>
Expand Down
Loading