Skip to content

Conversation

sheikhlimon
Copy link
Contributor

@sheikhlimon sheikhlimon commented Oct 6, 2025

Description

Fixes #825

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

  1. Added fallback for gitToken
    process.env.GITHUB_TOKEN
  2. Moved onBrokenMarkdownLinks configuration
    • Removed the old hooks object inside customFields.
    • Added:
      markdown: {
        hooks: {
          onBrokenMarkdownLinks: "warn",
        },
      },
    • Fixes the Docusaurus v4 deprecation warning about onBrokenMarkdownLinks.

Dependencies

  • n/a
  • n/a

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

Copy link

vercel bot commented Oct 6, 2025

@sheikhlimon is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 6, 2025

Synced data from Linked Issues

Labels:

  • level 1
  • recode
  • hacktoberfest-accepted

Assignees:

  • sheikhlimon

Milestones:

  • recode:launch 3.0

Copy link

github-actions bot commented Oct 6, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added hacktoberfest-accepted level 1 10 points recode this is label for leaderboard labels Oct 6, 2025
@Adez017 Adez017 added the don't-merge faced conflict issue or other dev related issue, dont merge PR label Oct 6, 2025
@sheikhlimon sheikhlimon force-pushed the fix/github-token-env branch 2 times, most recently from 30946f0 to 755d789 Compare October 6, 2025 19:15
@sheikhlimon
Copy link
Contributor Author

@Adez017 can you take a look at this now

@sheikhlimon
Copy link
Contributor Author

@iitzIrFan need your opinion on this

@Adez017
Copy link
Member

Adez017 commented Oct 7, 2025

i dont think we need this @sheikhlimon @iitzIrFan , the project is already working fine on all the locals and in production also . the main root issue is with the bangladesh server or internet . making this changes will make the redundant disruptions .

@Adez017
Copy link
Member

Adez017 commented Oct 7, 2025

@iitzIrFan @sanjay-kv , let me know your thoughts on this .

@sheikhlimon
Copy link
Contributor Author

sheikhlimon commented Oct 7, 2025

i dont think we need this @sheikhlimon @iitzIrFan , the project is already working fine on all the locals and in production also . the main root issue is with the bangladesh server or internet . making this changes will make the redundant disruptions .

What does local have to do with internet? I clearly explained this on my issue also it's not something I even faced. Someone else was having this issue. I even mentioned the link for that comment on my issue.

Note

  • This has nothing to do with production that's excluded 'hooks' which is clearly should not be placed inside customFields
  • This is classic example of just because it works on your computer doesn't mean it's gonna work on mine
  • Again this changes nothing in production
  • Someone had this issue before me only I found out when I tried to fix it

That's all. I think this is gonna clear the confusion and having a fallback is definitely not redundant.

@Adez017
Copy link
Member

Adez017 commented Oct 7, 2025

ok @sheikhlimon , by making any changes on the code base directly affect the production and in my opinion its working fine with most of the people . let me involve @sanjay-kv in this conversation

@sheikhlimon sheikhlimon force-pushed the fix/github-token-env branch from 755d789 to 0133865 Compare October 7, 2025 05:04
@sheikhlimon
Copy link
Contributor Author

ok @sheikhlimon , by making any changes on the code base directly affect the production and in my opinion its working fine with most of the people . let me involve @sanjay-kv in this conversation

sure and if you have time have a look at this https://claude.ai/share/5e39a70e-818d-4e31-8508-b4ce7b5d565c

@Adez017 Adez017 requested a review from sanjay-kv October 7, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't-merge faced conflict issue or other dev related issue, dont merge PR hacktoberfest-accepted level 1 10 points recode this is label for leaderboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: DOCUSAURUS_GIT_TOKEN missing in .env causes Leaderboard not to load on localhost
2 participants