Adding an page for ebooks section tab #836
Conversation
|
@Khushalsarode is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Synced data from Linked IssuesLabels:
Assignees:
Milestones:
|
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
github-actions
bot
added
hacktoberfest-accepted
level 1
|
Hi @Khushalsarode , is it correct that the current only added the mock data for the resource . |
src/pages/ebooks/index.tsx
Outdated
| category: string; | ||
| } | ||
|
|
||
| // Sample Ebook Data |
There was a problem hiding this comment.
this not seems feasible to me as this is only a mock data part , what we are expecting is an end to end solution . lets see what @sanjay-kv thinks
There was a problem hiding this comment.
This is actual link that was requested to be redirected from ebook tab.
Why do you think it's not "feasible", this is not mock data but the actual data.
Just it's like we are hard putting data into code because it's redirection links.
Tested more cards with mock data. Need to remove that comment
Please let me know if you have any suggestions.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new ebooks section page that allows users to browse and access learning resources. The implementation creates a dedicated ebooks page with search functionality and responsive design, replacing the previous direct external link with an internal page.
- Creates a new ebooks page with search and filtering capabilities
- Implements responsive card-based layout for displaying ebook resources
- Updates navigation to link to the internal ebooks page instead of external URL
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pages/ebooks/index.tsx | Main ebooks page component with search functionality and ebook card display |
| src/pages/ebooks/index.css | Comprehensive styling for the ebooks page including responsive design and animations |
| docusaurus.config.ts | Updates navigation link to point to internal ebooks page |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| category: string; | ||
| } | ||
|
|
||
| // Redirection URL Ebook Data |
There was a problem hiding this comment.
[nitpick] Corrected 'Redirection URL Ebook Data' to 'Ebook Redirection URL Data' for better clarity.
| // Redirection URL Ebook Data | |
| // Ebook Redirection URL Data |
Copilot uses AI. Check for mistakes.
| max-width: 1280px; | ||
| margin: 0 auto; | ||
| font-family: var(--ifm-font-family-base); | ||
|
|
There was a problem hiding this comment.
Empty line inside CSS rule block should be removed for cleaner code formatting.
Copilot uses AI. Check for mistakes.
|
|
||
| return ( | ||
| <div className="ebook-card" onClick={handleClick}> | ||
|
|
There was a problem hiding this comment.
Empty line inside JSX element should be removed for cleaner code formatting.
Copilot uses AI. Check for mistakes.
Description #338
Fixes #338
Type of Change
Changes Made
Checklist
npm run buildand attached screenshot(s) in this PR.