-
Notifications
You must be signed in to change notification settings - Fork 105
Feat/ci: add GitHub Actions workflow for linting #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@sheikhlimon is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Synced data from Linked IssuesLabels:
Assignees:
Milestones:
|
9679149
to
cb52811
Compare
@iitzIrFan any reason for lockfile to be ignored in git |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@sheikhlimon is this linting automatic, or user has to make code lint |
No this only runs |
5c47a70
to
d070234
Compare
Description
This PR adds a GitHub Actions workflow to automatically run linting on pushes and pull requests.
Fixes #838
Note:
npm ci
to ensure consistent dependency versions.package-lock.json
must be committed for CI to work correctly.npm install
can be used temporarily, but it may install different versions than intended, leading to inconsistent builds.Additional Note:
.github/workflows/lint.yml
).lint
script and ESLint/Prettier configuration are not yet merged.main
and CI will run successfully.Type of Change
Changes Made
Workflow Details
ubuntu-latest
.npm ci
.npm run lint
).Benefits
Dependencies
package.json
.npm ci
.package.json
includes alint
script (e.g.,"lint": "eslint ."
). The Node.js version in the workflow (node-version: 20
) should be compatible with local development.Explanation for Reviewers
Note on Dependencies:
package.json
andpackage-lock.json
should be committed, and onlynode_modules/
should be ignored.npm ci
to install exact dependency versions. Exceptions can be made if there’s a specific reason for not committing the lock file.Checklist
npm run build
and attached screenshot(s) in this PR.