Skip to content

fix: lint warnings and update ESLint config #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sanjay-kv merged 2 commits into from
Oct 21, 2025
Merged

fix: lint warnings and update ESLint config #959

sanjay-kv merged 2 commits into from
Oct 21, 2025

Conversation

@sheikhlimon
Copy link
Contributor

@sheikhlimon sheikhlimon commented Oct 19, 2025 •
edited
Loading

Description

Upgraded ESLint and related plugins to the latest versions and migrated from .eslintrc.cjs to a flat config eslint.config.mjs.
Turned off no-console warnings and ensured TypeScript and JSX files are linted correctly.

Fixes #958

Type of Change

  • Bug fix (non-breaking change that fixes linting and parsing issues)
  • Performance/Developer tooling improvement (ESLint + Prettier upgrade)
  • New feature
  • UI/UX improvement
  • Documentation update
  • Other (please specify):

Changes Made

  • Migrated ESLint config to eslint.config.mjs flat config
  • Updated ESLint to ^9.38.0, @typescript-eslint/parser and plugin to ^8.46.1
  • Updated eslint-plugin-react to ^7.37.5
  • Removed eslint-plugin-prettier and eslint-config-prettier from devDependencies
  • Disabled no-console warnings
  • Ensured React globals are defined for TSX files
  • Kept TypeScript warnings for unused variables and any usage
  • Added ignores for node_modules, build, .docusaurus, static, dist

Dependencies

  • ESLint ^9.38.0
  • @typescript-eslint/parser ^8.46.1
  • @typescript-eslint/eslint-plugin ^8.46.1
  • eslint-plugin-react ^7.37.5

Checklist

  • My code follows the style guidelines of this project.
  • I have tested linting on all TS/JSX/TSX/JS files.
  • Console warnings for intentional logs are suppressed (no-console off).
  • I ran npm run build successfully.
  • This PR addresses the assigned issue.

@vercel
Copy link
Contributor

vercel bot commented Oct 19, 2025

@sheikhlimon is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Oct 19, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added hacktoberfest-accepted recode this is label for leaderboard labels Oct 19, 2025
@github-actions
Copy link

github-actions bot commented Oct 19, 2025

Synced data from Linked Issues

Labels:

  • level 1
  • recode
  • hacktoberfest-accepted

Assignees:

  • None

Milestones:

  • None

@sheikhlimon
chore: remove eslint-plugin-prettier and eslint-config-prettier
18e8f5d 
ESLint now only handles linting
Formatting is fully managed by Prettier
No changes to linting rules or TS/JS/TSX configuration
@sheikhlimon sheikhlimon marked this pull request as ready for review October 19, 2025 10:26
@sanjay-kv sanjay-kv added the level 2 30 points label Oct 20, 2025
@sanjay-kv sanjay-kv moved this to In Progress in @recode-web Oct 20, 2025
@sanjay-kv sanjay-kv added this to the recode:launch 3.0 milestone Oct 20, 2025
@vercel
Copy link
Contributor

vercel bot commented Oct 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Oct 20, 2025 9:49am

@sanjay-kv
Copy link
Member

sanjay-kv commented Oct 20, 2025

@sheikhlimon vercel is down at the moment any PR might take some time

@sheikhlimon
Copy link
Contributor Author

sheikhlimon commented Oct 20, 2025

@sheikhlimon vercel is down at the moment any PR might take some time

Yeah I noticed that. What's the issue though

@sanjay-kv
Copy link
Member

sanjay-kv commented Oct 20, 2025

https://www.vercel-status.com/
server issues with cdn

@sheikhlimon
Copy link
Contributor Author

sheikhlimon commented Oct 20, 2025 •
edited
Loading

https://www.vercel-status.com/ server issues with cdn

🤣🤣 This guy works at Amazon btw
Screenshot_20251020-155042

@sanjay-kv
Copy link
Member

sanjay-kv commented Oct 20, 2025

@sheikhlimon

https://news.sky.com/story/huge-internet-outage-knocks-out-snapchat-amazon-and-multiple-other-websites-and-apps-13453810

yes saw this news.

@iitzIrFan iitzIrFan self-requested a review October 20, 2025 16:31
iitzIrFan
iitzIrFan approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! @sheikhlimon
@sanjay-kv Ready for merge.

@iitzIrFan iitzIrFan added the Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. label Oct 20, 2025
@sanjay-kv sanjay-kv merged commit 6066bb0 into recodehive:main Oct 21, 2025
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Oct 21, 2025
@sheikhlimon sheikhlimon deleted the fix/lint-warnings branch October 22, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanjay-kv sanjay-kv sanjay-kv approved these changes

@iitzIrFan iitzIrFan iitzIrFan approved these changes

Assignees

@sheikhlimon sheikhlimon

Labels

hacktoberfest-accepted level 2 30 points Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. recode this is label for leaderboard

Projects

@recode-web
Status: Done

Milestone

recode:launch 3.0

Development

Successfully merging this pull request may close these issues.

Upgrade ESLint Configuration to Flat Config for TypeScript, JSX, and JavaScript

3 participants

@sheikhlimon @sanjay-kv @iitzIrFan