Skip to content

Conversation

@kanishka-commits
Copy link
Contributor

Description

Fixes #967

This PR addresses theme inconsistencies across multiple components on the website, improving visual clarity and readability in both light and dark modes. Specifically:

  1. GitHub Sign-In Button
    • Updated the button styling to dynamically adapt its color and icon contrast according to the active theme.
    • Ensures visibility in both light and dark modes.
    • Screenshots/recording:
Screen.Recording.2025-10-20.at.3.14.11.PM.mov
  1. Sanjay’s Substack Popup
    • The popup title was overlapping with other CSS, which caused its color to change even when it was hardcoded.
    • Adjusted styling to prevent conflicts and ensure the title remains readable in both light and dark modes.
    • Screenshots/recording:
Screen.Recording.2025-10-20.at.2.22.15.PM.mov
  1. GitHub Achievement Badges
    • Adjusted description text color for proper contrast in light mode.
    • Ensures readability and accessibility across themes.
    • Screenshots/recording:
Screen.Recording.2025-10-20.at.3.15.34.PM.mov

Suggested Fixes Implemented:

  • Applied theme-aware color variables across all affected components.
  • Ensured WCAG-compliant contrast for text and background.
  • Tested UI elements after theme switching to confirm consistent appearance.

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

  • Updated GitHub Sign-In button styling to be theme-aware.
  • Fixed Sanjay’s Substack popup title color for readability.
  • Adjusted GitHub achievement badges description text color in light mode.
  • Tested all components in both light and dark modes for consistency.

Dependencies

  • No new dependencies introduced.
  • No version updates required.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices.
  • My changes do not generate new console warnings or errors.
  • I ran npm run build and attached screenshot(s)/recordings in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

@vercel
Copy link
Contributor

vercel bot commented Oct 20, 2025

@kanishka-commits is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added hacktoberfest-accepted recode this is label for leaderboard labels Oct 20, 2025
@github-actions
Copy link

Synced data from Linked Issues

Labels:

  • level 3
  • recode
  • hacktoberfest-accepted

Assignees:

  • kanishka-commits

Milestones:

  • recode:launch 3.0

@iitzIrFan iitzIrFan added the under review Review under the maintainers or the admins label Oct 20, 2025
@iitzIrFan iitzIrFan moved this to In Progress in @recode-web Oct 20, 2025
@iitzIrFan iitzIrFan self-requested a review October 20, 2025 17:33
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @kanishka-commits
@sanjay-kv Ready for merge.

@iitzIrFan iitzIrFan added the Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. label Oct 20, 2025
@sanjay-kv sanjay-kv added the level 3 50 points label Oct 21, 2025
@vercel
Copy link
Contributor

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Oct 21, 2025 2:43pm

@sanjay-kv sanjay-kv merged commit 9a1787e into recodehive:main Oct 21, 2025
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Oct 21, 2025
@kanishka-commits
Copy link
Contributor Author

@sanjay-kv @iitzIrFan
Hey! When I opened this issue, it was under GSSoC. Could you please add the GSSoC label to it?
Thanks!

@iitzIrFan iitzIrFan added gssoc25 and removed under review Review under the maintainers or the admins labels Oct 21, 2025
@iitzIrFan
Copy link
Member

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc25 hacktoberfest-accepted level 3 50 points Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. recode this is label for leaderboard

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: 3 Major Issues Related to Theme Inconsistencies

3 participants