Skip to content

Commit 9cc90cf

Browse files
committed
Fixed escaping of query parameters
1 parent 648a6a9 commit 9cc90cf

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/recombee_api_client.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
require 'open-uri'
77
require 'net/https'
88
require 'timeout'
9+
require 'cgi'
910

1011
require 'recombee_api_client/errors'
1112
Gem.find_files('recombee_api_client/api/*.rb').each { |path| require path }
@@ -97,7 +98,6 @@ def process_request_uri(request)
9798
uri = request.path
9899
uri.slice! ('/{databaseId}/')
99100
uri += query_parameters_to_url(request)
100-
uri = URI.escape uri
101101
uri
102102
end
103103

@@ -111,8 +111,8 @@ def query_parameters_to_url(req)
111111
end
112112

113113
def format_query_parameter_value(value)
114-
return value unless value.kind_of?(Array)
115-
value.join(',')
114+
return CGI::escape("#{value}") unless value.kind_of?(Array)
115+
value.map{|v| CGI::escape("#{v}")}.join(',')
116116
end
117117

118118
# Sign request with HMAC, request URI must be exacly the same

lib/recombee_api_client/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module RecombeeApiClient
2-
VERSION = '1.2.4'
2+
VERSION = '1.2.5'
33
end

0 commit comments

Comments
 (0)