Coping with non-clustered cases in contacts dataframe#121
Open
isaac-florence wants to merge 3 commits intoreconhub:masterfrom
Open
Coping with non-clustered cases in contacts dataframe#121isaac-florence wants to merge 3 commits intoreconhub:masterfrom
isaac-florence wants to merge 3 commits intoreconhub:masterfrom
Conversation
added 3 commits
December 28, 2020 10:35
No change to default behaviour. Fixes issue with igraph turning NA to 'NA' and assigning non-clustered cases to same cluster (only issue where "from" col in contacts is NA)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because cases in the linelist who do not appear in the contacts dataframe with from as NA do not have their node attributes displayed, just their ID, it is necessary to include them in the contacts. However, {igraph} in the get_clusters function turns NA to 'NA' and so falsely considers non-connected cases as one cluster.
Although this does not change default behaviour it does allow for users to have a linelist returned which does not assign clusters to non-clustered cases.
The minor fix was required due to an issue in copying an epicontacts object but has now been tested and works as expected