feat: refactor CategoryStatus to extend CommonStatus and remove redundant code

Author: aspirantzhang

contexts/CategoryManagement/Domain/Models/CategoryStatus.php

@@ -4,68 +4,6 @@
 
 namespace Contexts\CategoryManagement\Domain\Models;
 
-use App\Exceptions\BizException;
+use Contexts\Shared\ValueObjects\CommonStatus;
 
-class CategoryStatus
-{
-    public const SUBSPENDED = 'subspended';
-
-    public const ACTIVE = 'active';
-
-    public const DELETED = 'deleted';
-
-    public function __construct(private string $value)
-    {
-        if (! in_array($value, [self::SUBSPENDED, self::ACTIVE, self::DELETED])) {
-            throw BizException::make('Invalid status: :status')
-                ->with('status', $value);
-        }
-    }
-
-    public static function subspended(): self
-    {
-        return new self(self::SUBSPENDED);
-    }
-
-    public static function active(): self
-    {
-        return new self(self::ACTIVE);
-    }
-
-    public static function deleted(): self
-    {
-        return new self(self::DELETED);
-    }
-
-    public function transitionTo(CategoryStatus $target): self
-    {
-        $validTransitions = match ($this->value) {
-            self::SUBSPENDED => [self::ACTIVE, self::DELETED],
-            self::ACTIVE => [self::SUBSPENDED, self::DELETED],
-            default => [],
-        };
-
-        if (! in_array($target->value, $validTransitions)) {
-            throw BizException::make('Cannot transition from :from to :to')
-                ->with('from', $this->value)
-                ->with('to', $target->value);
-        }
-
-        return $target;
-    }
-
-    public static function fromString(string $status): self
-    {
-        return new self($status);
-    }
-
-    public function getValue(): string
-    {
-        return $this->value;
-    }
-
-    public function equals(self $status): bool
-    {
-        return $this->value === $status->value;
-    }
-}
+class CategoryStatus extends CommonStatus {}

contexts/CategoryManagement/Tests/Unit/Domain/Models/CategoryIdTest.php

@@ -0,0 +1,71 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Contexts\Shared\ValueObjects;
+
+use App\Exceptions\BizException;
+
+abstract class CommonStatus
+{
+    public const SUBSPENDED = 'subspended';
+
+    public const ACTIVE = 'active';
+
+    public const DELETED = 'deleted';
+
+    final public function __construct(private string $value)
+    {
+        if (! in_array($value, [static::SUBSPENDED, static::ACTIVE, static::DELETED])) {
+            throw BizException::make('Invalid status: :status')
+                ->with('status', $value);
+        }
+    }
+
+    public static function subspended(): static
+    {
+        return new static(static::SUBSPENDED);
+    }
+
+    public static function active(): static
+    {
+        return new static(static::ACTIVE);
+    }
+
+    public static function deleted(): static
+    {
+        return new static(static::DELETED);
+    }
+
+    public function transitionTo(CommonStatus $target): static
+    {
+        $validTransitions = match ($this->value) {
+            static::SUBSPENDED => [static::ACTIVE, static::DELETED],
+            static::ACTIVE => [static::SUBSPENDED, static::DELETED],
+            default => [],
+        };
+
+        if (! in_array($target->value, $validTransitions)) {
+            throw BizException::make('Cannot transition from :from to :to')
+                ->with('from', $this->value)
+                ->with('to', $target->value);
+        }
+
+        return new static($target->value);
+    }
+
+    public static function fromString(string $status): static
+    {
+        return new static($status);
+    }
+
+    public function getValue(): string
+    {
+        return $this->value;
+    }
+
+    public function equals(CommonStatus $status): bool
+    {
+        return $this->value === $status->value;
+    }
+}

contexts/Shared/ValueObjects/CommonStatus.php

@@ -3,54 +3,56 @@
 declare(strict_types=1);
 
 use App\Exceptions\BizException;
-use Contexts\CategoryManagement\Domain\Models\CategoryStatus;
+use Contexts\Shared\ValueObjects\CommonStatus;
+
+class ConcreteStatus extends CommonStatus {}
 
 it('can be created', function (string $validValue) {
-    $categoryStatus = new CategoryStatus($validValue);
+    $categoryStatus = new ConcreteStatus($validValue);
 
     expect($categoryStatus->getValue())->toBe($validValue);
-})->with(['subspended', 'active', 'subspended', 'deleted']);
+})->with(['subspended', 'active', 'deleted']);
 
 it('throws an exception when the status is invalid', function (string $invalidValue) {
     $this->expectException(BizException::class);
 
-    new CategoryStatus($invalidValue);
+    new ConcreteStatus($invalidValue);
 })->with(['invalid', 'status']);
 
 it('can be transitioned to another status', function (string $initialValue, string $targetValue) {
-    $categoryStatus = new CategoryStatus($initialValue);
-    $newStatus = $categoryStatus->transitionTo(CategoryStatus::{$targetValue}());
+    $categoryStatus = new ConcreteStatus($initialValue);
+    $newStatus = $categoryStatus->transitionTo(ConcreteStatus::{$targetValue}());
 
     expect($newStatus->getValue())->toBe($targetValue);
 })->with([
     ['subspended', 'active'],
 ]);
 
 it('throws an exception when transitioning to active from active', function () {
-    $categoryStatus = new CategoryStatus('active');
+    $categoryStatus = new ConcreteStatus('active');
 
     $this->expectException(BizException::class);
 
-    $categoryStatus->transitionTo(CategoryStatus::active());
+    $categoryStatus->transitionTo(ConcreteStatus::active());
 });
 
 it('can create from string with valid status', function (string $validValue) {
-    $categoryStatus = CategoryStatus::fromString($validValue);
+    $categoryStatus = ConcreteStatus::fromString($validValue);
 
     expect($categoryStatus->getValue())->toBe($validValue);
-})->with(['subspended', 'active', 'subspended', 'deleted']);
+})->with(['subspended', 'active', 'deleted']);
 
 it('throws an exception when creating from invalid string status', function (string $invalidValue) {
     $this->expectException(BizException::class);
 
-    CategoryStatus::fromString($invalidValue);
+    ConcreteStatus::fromString($invalidValue);
 })->with(['invalid', 'status']);
 
 it('checks if two statuses are equal', function (string $status) {
-    $status1 = new CategoryStatus($status);
-    $status2 = new CategoryStatus($status);
-    $differentStatus = $status === 'subspended' ? CategoryStatus::active() : CategoryStatus::subspended();
+    $status1 = new ConcreteStatus($status);
+    $status2 = new ConcreteStatus($status);
+    $differentStatus = $status === 'subspended' ? ConcreteStatus::active() : ConcreteStatus::subspended();
 
     expect($status1->equals($status2))->toBeTrue();
     expect($status1->equals($differentStatus))->toBeFalse();
-})->with(['subspended', 'active', 'subspended', 'deleted']);
+})->with(['subspended', 'active', 'deleted']);