tv next test (#7)

* path

* honest test

Author: TomasVotruba

phpstan.neon

@@ -2,6 +2,7 @@ parameters:
     level: 8
 
     paths:
+        - bin
         - src
         - tests
 

src/Analyzer/UnusedDefinitionsAnalyzer.php

@@ -15,6 +15,7 @@
 use Rector\Behastan\ValueObject\Mask\SkippedMask;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\Finder\SplFileInfo;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Behastan\Tests\Analyzer\UnusedDefinitionsAnalyzer\UnusedDefinitionsAnalyzerTest
@@ -42,7 +43,18 @@ public function __construct(
      */
     public function analyse(array $contextFiles, array $featureFiles): array
     {
+        Assert::allIsInstanceOf($contextFiles, SplFileInfo::class);
+        foreach ($contextFiles as $contextFile) {
+            Assert::endsWith($contextFile->getFilename(), '.php');
+        }
+
+        Assert::allIsInstanceOf($featureFiles, SplFileInfo::class);
+        foreach ($featureFiles as $featureFile) {
+            Assert::endsWith($featureFile->getFilename(), '.feature');
+        }
+
         $maskCollection = $this->definitionMasksResolver->resolve($contextFiles);
+
         $this->maskCollectionStatsPrinter->printStats($maskCollection);
 
         $featureInstructions = $this->usedInstructionResolver->resolveInstructionsFromFeatureFiles($featureFiles);

…nalyzer/Fixture/Contexts/SomeContext.php …r/Fixture/EverythingUsed/SomeContext.phptests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/Contexts/SomeContext.php renamed to tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/EverythingUsed/SomeContext.php tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/Contexts/SomeContext.php renamed to tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/EverythingUsed/SomeContext.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Analyzer\UnusedDefinitionsAnalyzer\Fixture\Contexts;
+namespace Rector\Behastan\Tests\Analyzer\UnusedDefinitionsAnalyzer\Fixture\EverythingUsed;
 
 use Behat\Behat\Context\Context;
 use Behat\Step\Given;
@@ -11,18 +11,20 @@ final class LoginContext implements Context
     #[Given('I am on the login page')]
     public function iAmOnTheLoginPage(): void
     {
-        // open login page
     }
 
     #[When('I login as :username')]
     public function iLoginAs(string $username): void
     {
-        // fill credentials and submit form
+    }
+
+    #[When('I login with :email email')]
+    public function iLoginWith(string $email): void
+    {
     }
 
     #[When('The :username is logged in')]
     public function isLoggedIn(string $username): void
     {
-        // fill credentials and submit form
     }
 }

…nsAnalyzer/Fixture/Features/some.feature …yzer/Fixture/EverythingUsed/some.featuretests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/Features/some.feature renamed to tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/EverythingUsed/some.feature tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/Features/some.feature renamed to tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/EverythingUsed/some.feature

@@ -2,4 +2,5 @@ Feature: User login
     Scenario: Successful login
         Given I am on the login page
         When I login as "Tomas"
+        When I login with "[email protected]" email
         Then The "Tomas" is logged in

tests/Fixture/BehatContext.php …zer/Fixture/UnusedMasks/BehatContext.phptests/Fixture/BehatContext.php renamed to tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/UnusedMasks/BehatContext.php tests/Fixture/BehatContext.php renamed to tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/UnusedMasks/BehatContext.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\Behastan\Tests\Fixture;
+namespace Rector\Behastan\Tests\Analyzer\UnusedDefinitionsAnalyzer\Fixture\UnusedMasks;
 
 final class BehatContext
 {

tests/Fixture/some.feature …nalyzer/Fixture/UnusedMasks/some.featuretests/Fixture/some.feature renamed to tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/UnusedMasks/some.feature tests/Fixture/some.feature renamed to tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/UnusedMasks/some.feature

@@ -7,6 +7,7 @@
 use Rector\Behastan\Analyzer\UnusedDefinitionsAnalyzer;
 use Rector\Behastan\Finder\BehatMetafilesFinder;
 use Rector\Behastan\Tests\AbstractTestCase;
+use Rector\Behastan\ValueObject\Mask\AbstractMask;
 
 final class UnusedDefinitionsAnalyzerTest extends AbstractTestCase
 {
@@ -19,16 +20,34 @@ protected function setUp(): void
         $this->unusedDefinitionsAnalyzer = $this->make(UnusedDefinitionsAnalyzer::class);
     }
 
-    public function test(): void
+    public function testEverythingUsed(): void
     {
-        $featureFiles = BehatMetafilesFinder::findFeatureFiles([__DIR__ . '/Fixture/Features']);
-        $this->assertCount(1, $featureFiles);
+        $featureFiles = BehatMetafilesFinder::findFeatureFiles([__DIR__ . '/Fixture/EverythingUsed']);
+        $contextFiles = BehatMetafilesFinder::findContextFiles([__DIR__ . '/Fixture/EverythingUsed']);
 
-        $contextFiles = BehatMetafilesFinder::findContextFiles([__DIR__ . '/Fixture/Contexts']);
+        $this->assertCount(1, $featureFiles);
         $this->assertCount(1, $contextFiles);
 
         $unusedDefinitions = $this->unusedDefinitionsAnalyzer->analyse($contextFiles, $featureFiles);
 
         $this->assertCount(0, $unusedDefinitions);
     }
+
+    public function testFoundMask(): void
+    {
+        $featureFiles = BehatMetafilesFinder::findFeatureFiles([__DIR__ . '/Fixture/UnusedMasks']);
+        $contextFiles = BehatMetafilesFinder::findContextFiles([__DIR__ . '/Fixture/UnusedMasks']);
+
+        $this->assertCount(1, $featureFiles);
+        $this->assertCount(1, $contextFiles);
+
+        $unusedMasks = $this->unusedDefinitionsAnalyzer->analyse($contextFiles, $featureFiles);
+        $this->assertCount(1, $unusedMasks);
+        $this->assertContainsOnlyInstancesOf(AbstractMask::class, $unusedMasks);
+
+        /** @var AbstractMask $unusedMask */
+        $unusedMask = $unusedMasks[0];
+        $this->assertSame(__DIR__ . '/Fixture/UnusedMasks/BehatContext.php', $unusedMask->filePath);
+        $this->assertSame('never used', $unusedMask->mask);
+    }
 }