Add shouldImplement and related missing tests
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@TomasVotruba ready to review for this one too. |
Prometee
changed the title
shouldImplement and related missing tests
TomasVotruba
approved these changes
Mar 28, 2025
Member
|
Beautiful work! Tidy code and simple test 👏 thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
rules-tests/Rector/Class_/PromisesToAssertsRector/Fixture/should_be_instance_of.php.incandsrc/Enum/ProphecyPromisesToPHPUnitAssertMap.phpfiles to enhance the conversion of PhpSpec promises to PHPUnit assertions. The most important changes include adding new test cases and updating the mapping of promises to assertions.Enhancements to test cases:
rules-tests/Rector/Class_/PromisesToAssertsRector/Fixture/should_be_instance_of.php.inc: Added new test cases to convert various PhpSpec promises (shouldBeAnInstanceOf,shouldHaveType,shouldReturnAnInstanceOf,shouldImplement) to their corresponding PHPUnit assertions (assertInstanceOf).Updates to promise-to-assertion mapping:
src/Enum/ProphecyPromisesToPHPUnitAssertMap.php: Updated thePROMISES_BY_ASSERT_METHODarray to include theshouldImplementpromise under theassertInstanceOfassertion.