remove unused ImplicitLetInitializationRector

.github/workflows/code_analysis.yaml

@@ -18,7 +18,7 @@ jobs:
                 actions:
                     -
                         name: 'Active Classes'
-                        run: vendor/bin/class-leak check config bin src rules --skip-type="Rector\PhpSpecToPHPUnit\Rector\Class_\ImplicitLetInitializationRector"
+                        run: vendor/bin/class-leak check config bin src rules
 
                     -
                         name: "Composer Analyser"

composer.json

@@ -22,7 +22,8 @@
         "phpstan/extension-installer": "^1.3",
         "tomasvotruba/class-leak": "^2.0",
         "tracy/tracy": "^2.10",
-        "shipmonk/composer-dependency-analyser": "^1.8"
+        "shipmonk/composer-dependency-analyser": "^1.8",
+        "symplify/phpstan-extensions": "^12.0"
     },
     "autoload": {
         "psr-4": {

phpstan.neon

@@ -9,23 +9,21 @@ parameters:
         - rules-tests
 
     reportUnmatchedIgnoredErrors: false
-
     treatPhpDocTypesAsCertain: false
+    errorFormat: symplify
 
     excludePaths:
         - */Fixture/*
 
     ignoreErrors:
-        # bool property
+        # bool property changed inside another call, false positive
         -
              message: '#Negated boolean expression is always true#'
              path: src/NodeFactory/AssertMethodCallFactory.php
 
         - '#PHPDoc tag @return contains generic type PhpParser\\Node\\Stmt\\Expression<(.*?)> but class PhpParser\\Node\\Stmt\\Expression is not generic#'
 
         # known value
-        - '#Cannot call method toString\(\) on PhpParser\\Node\\Identifier\|null#'
         - '#Call to an undefined method PhpParser\\Node\\Expr\|PhpParser\\Node\\Identifier\:\:toString\(\)#'
 
-        -
-            identifier: phpstanApi.instanceofType
+        - identifier: phpstanApi.instanceofType

rules/Rector/Class_/PhpSpecClassToPHPUnitClassRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt\Class_;
 use Rector\PhpSpecToPHPUnit\Naming\PhpSpecRenaming;
+use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -38,6 +39,10 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
+        if (! $node->name instanceof Identifier) {
+            return null;
+        }
+
         // skip already renamed
         /** @var string $className */
         $className = $node->name->toString();
@@ -48,7 +53,7 @@ public function refactor(Node $node): ?Node
         // rename class and parent class
         $phpunitTestClassName = $this->phpSpecRenaming->createPHPUnitTestClassName($node);
         $node->name = new Identifier($phpunitTestClassName);
-        $node->extends = new FullyQualified('PHPUnit\Framework\TestCase');
+        $node->extends = new FullyQualified(PHPUnitClassName::TEST_CASE);
 
         $this->visibilityManipulator->makeFinal($node);
 

src/DocFactory.php

@@ -5,6 +5,7 @@
 namespace Rector\PhpSpecToPHPUnit;
 
 use PhpParser\Comment\Doc;
+use Rector\PhpSpecToPHPUnit\Enum\PHPUnitClassName;
 use Rector\PhpSpecToPHPUnit\ValueObject\ServiceMock;
 
 final class DocFactory
@@ -14,7 +15,7 @@ public static function createForMockAssign(ServiceMock $serviceMock): Doc
         $comment = sprintf(
             "/** @var \%s|\%s $%s */",
             $serviceMock->getMockClassName(),
-            'PHPUnit\Framework\MockObject\MockObject',
+            PHPUnitClassName::MOCK_OBJECT,
             $serviceMock->getVariableName() . 'Mock'
         );
 
@@ -27,7 +28,7 @@ public static function createForMockProperty(ServiceMock $serviceMock): Doc
             "/**%s * @var \%s|\%s%s */",
             PHP_EOL,
             $serviceMock->getMockClassName(),
-            'PHPUnit\Framework\MockObject\MockObject',
+            PHPUnitClassName::MOCK_OBJECT,
             PHP_EOL
         );
 

src/Enum/PHPUnitClassName.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PhpSpecToPHPUnit\Enum;
+
+final class PHPUnitClassName
+{
+    public const MOCK_OBJECT = 'PHPUnit\Framework\MockObject\MockObject';
+}

src/NodeFactory/LetMockNodeFactory.php

@@ -18,6 +18,7 @@
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\PhpParser\Node\NodeFactory;
 use Rector\PhpSpecToPHPUnit\DocFactory;
+use Rector\PhpSpecToPHPUnit\Enum\PHPUnitClassName;
 use Rector\PhpSpecToPHPUnit\Exception\ShouldNotHappenException;
 use Rector\PhpSpecToPHPUnit\ValueObject\ServiceMock;
 
@@ -87,7 +88,7 @@ public function createMockPropertyAssignExpressions(array $params): array
 
     private function crateMockProperty(string $parameterName): Property
     {
-        $objectType = new ObjectType('PHPUnit\Framework\MockObject\MockObject');
+        $objectType = new ObjectType(PHPUnitClassName::MOCK_OBJECT);
         return $this->nodeFactory->createPrivatePropertyFromNameAndType($parameterName, $objectType);
     }