Skip to content

Fix logical comparision #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Jan 16, 2025
Merged

Fix logical comparision #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b030f94
Fix logical comparision
iNem0o Jan 16, 2025
ea76346
Fix tests and remove redundant import
iNem0o Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...owngradePhp80/Rector/Expression/DowngradeThrowExprRector/Fixture/no_isset_on_expr.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ final class NoIssetOnExpr
{
public function run($backedEnumClassName, $backedEnumValue)
{
if ($backedEnumClassName::tryFrom($backedEnumValue) !== null) {
if ($backedEnumClassName::tryFrom($backedEnumValue) === null) {
throw new \Symfony\Component\DependencyInjection\Exception\RuntimeException(sprintf('Enum value "%s" is not backed by "%s".', $backedEnumValue, $backedEnumClassName));
}
return $backedEnumClassName::tryFrom($backedEnumValue);
Expand Down
3 changes: 1 addition & 2 deletions rules/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\BinaryOp\Coalesce;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\Expr\ConstFetch;
Expand Down Expand Up @@ -253,7 +252,7 @@ private function createIf(Coalesce $coalesce, Throw_ $throw): If_
if ($conditionalExpr instanceof Variable || $conditionalExpr instanceof ArrayDimFetch || $conditionalExpr instanceof PropertyFetch) {
$booleanNot = new BooleanNot(new Isset_([$conditionalExpr]));
} else {
$booleanNot = new NotIdentical($conditionalExpr, new ConstFetch(new Name('null')));
$booleanNot = new Identical($conditionalExpr, new ConstFetch(new Name('null')));
}

return new If_($booleanNot, [
Expand Down
Loading