Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\PreferPHPUnitSelfCallRector\Fixture;

use PHPUnit\Framework\TestCase;

final class SkipDifferentObject extends TestCase
{
public function testMe()
{
$this->transport('webhook')
->dispatched()
->assertCount(1)
->assertContains(SendWebhookMessage::class);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector\Fixture;

use PHPUnit\Framework\TestCase;

final class SkipDifferentObjectType extends TestCase
{
public function testMe()
{
$someMock = $object->execute()::createMock('stdClass');
}
}
11 changes: 11 additions & 0 deletions rules/CodeQuality/NodeAnalyser/AssertMethodAnalyzer.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Type\ObjectType;
use Rector\NodeNameResolver\NodeNameResolver;
use Rector\NodeTypeResolver\NodeTypeResolver;
use Rector\PHPUnit\CodeQuality\Enum\NonAssertStaticableMethods;
use Rector\PHPUnit\Enum\PHPUnitClassName;
use Rector\Reflection\ReflectionResolver;
Expand All @@ -17,11 +19,20 @@
public function __construct(
private NodeNameResolver $nodeNameResolver,
private ReflectionResolver $reflectionResolver,
private NodeTypeResolver $nodeTypeResolver
) {
}

public function detectTestCaseCall(MethodCall|StaticCall $call): bool
{
$objectCaller = $call instanceof MethodCall
? $call->var
: $call->class;

if (! $this->nodeTypeResolver->isObjectType($objectCaller, new ObjectType('PHPUnit\Framework\TestCase'))) {
return false;
}

$methodName = $this->nodeNameResolver->getName($call->name);
if (! str_starts_with((string) $methodName, 'assert') && ! in_array(
$methodName,
Expand Down
Loading