[Php74] Skip closure in attribute on ClosureToArrowFunctionRector (#7834)

* [Php74] Skip closure in attribute on ClosureToArrowFunctionRector

* [Php74] Skip closure in attribute on ClosureToArrowFunctionRector

* [Php74] Skip closure in attribute on ClosureToArrowFunctionRector

Author: samsonasik

rules-tests/Php74/Rector/Closure/ClosureToArrowFunctionRector/Fixture/skip_inside_attribute.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Closure\ClosureToArrowFunctionRector\Fixture;
+
+class SkipInsideAttribute
+{
+    #[Idempotency(key: static function(Command $command) : IdempotencyKey {
+        return new IdempotencyKey(
+           'key',
+        );
+    }, seconds: 604_800)]
+    public function __invoke(Command $command)
+    {}
+}

rules/Php74/Rector/Closure/ClosureToArrowFunctionRector.php

@@ -73,6 +73,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($node->getAttribute(AttributeKey::IS_CLOSURE_IN_ATTRIBUTE) === true) {
+            return null;
+        }
+
         $attributes = $node->getAttributes();
         unset($attributes[AttributeKey::ORIGINAL_NODE]);
 

src/NodeTypeResolver/Node/AttributeKey.php

@@ -187,6 +187,11 @@ final class AttributeKey
      */
     public const IS_ARRAY_IN_ATTRIBUTE = 'is_array_in_attribute';
 
+    /**
+     * @var string
+     */
+    public const IS_CLOSURE_IN_ATTRIBUTE = 'is_closure_in_attribute';
+
     /**
      * @var string
      */

src/PhpParser/NodeVisitor/ContextNodeVisitor.php

@@ -145,6 +145,10 @@ static function (Node $subNode): null {
                     $subNode->setAttribute(AttributeKey::IS_ARRAY_IN_ATTRIBUTE, true);
                 }
 
+                if ($subNode instanceof Closure) {
+                    $subNode->setAttribute(AttributeKey::IS_CLOSURE_IN_ATTRIBUTE, true);
+                }
+
                 return null;
             }
         );