Move instanceof PHPStan Type to ->is*() take 1

[samsonasik]

Cherry-pick from #6415
Ref rectorphp/rector#8815 (comment)

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[samsonasik]

Tested on CodeIgniter 4 project, it somehow cause invalid change on non-native property:

➜  CodeIgniter4 git:(develop) ✗ vendor/bin/rector 
 956/956 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
1 file with changes
===================

1) system/Database/Forge.php:572

    ---------- begin diff ----------
@@ @@
             }

             // Most databases don't support creating indexes from within the CREATE TABLE statement
-            if (! empty($this->keys)) {
+            if ($this->keys !== []) {
                 for ($i = 0, $sqls = $this->_processIndexes($table), $c = count($sqls); $i < $c; $i++) {
                     $this->db->query($sqls[$i]);
                 }
    ----------- end diff -----------

Applied rules:
 * SimplifyEmptyCheckOnEmptyArrayRector
 * ClassPropertyAssignToConstructorPromotionRector

which hsould be skipped, which ! empty() cover null check as well, I will look it first to avoid regression if possible, some is*() method seems cause some magic check on union.

[samsonasik]

After some check, SimplifyEmptyCheckOnEmptyArrayRector check on default value as well, so seems ok, and there is fixture for it

rector-src/rules-tests/CodeQuality/Rector/Empty_/SimplifyEmptyCheckOnEmptyArrayRector/Fixture/non_typed_property_has_default_value_never_assigned.php.inc

Lines 5 to 31 in 3949fc2

	final class NonTypedPropertyHasDefaultValueNeverAssigned
	{
	/** @var array */
	public $property = [];
	public function isEmpty(): bool
	{
	return empty($this->property);
	}
	}
	?>
	-----
	<?php
	namespace Rector\Tests\CodeQuality\Rector\Empty_\SimplifyEmptyCheckOnEmptyArrayRector\Fixture;
	final class NonTypedPropertyHasDefaultValueNeverAssigned
	{
	/** @var array */
	public $property = [];
	public function isEmpty(): bool
	{
	return $this->property === [];
	}
	}

which property be null is rather rare, I also create a patch on CodeIgniter4 side based on it:

• refactor: use compare empty array on Forge on keys property codeigniter4/CodeIgniter4#9267