Skip to content

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 16, 2025

@samsonasik
Copy link
Member Author

Current PHPStan notice:

------------------------------------------------------------------------
  rules/CodeQuality/NodeAnalyzer/MissingPropertiesResolver.php:37
 ------------------------------------------------------------------------
  - '#Call to deprecated method hasProperty\(\) of class PHPStan\\Reflection\\ClassReflection\:
Use hasInstanceProperty or hasStaticProperty instead#'
  🪪 method.deprecated
 ------------------------------------------------------------------------

 ------------------------------------------------------------------------
  rules/CodeQuality/Rector/Class_/ConvertStaticToSelfRector.php:146
 ------------------------------------------------------------------------
  - '#Call to deprecated method hasProperty\(\) of class PHPStan\\Reflection\\ClassReflection\:
Use hasInstanceProperty or hasStaticProperty instead#'
  🪪 method.deprecated
 ------------------------------------------------------------------------

 ------------------------------------------------------------------------
  rules/CodeQuality/Rector/Class_/ConvertStaticToSelfRector.php:160
 ------------------------------------------------------------------------
  - '#Call to deprecated method getProperty\(\) of class PHPStan\\Reflection\\ClassReflection\:
Use getInstanceProperty or getStaticProperty#'
  🪪 method.deprecated
 ------------------------------------------------------------------------

 ------------------------------------------------------------------------
  rules/CodeQuality/Rector/Isset_/IssetOnPropertyObjectToPropertyExistsRector.php:134
 ------------------------------------------------------------------------
  - '#Call to deprecated method hasProperty\(\) of class PHPStan\\Reflection\\ClassReflection\:
Use hasInstanceProperty or hasStaticProperty instead#'
  🪪 method.deprecated
 ------------------------------------------------------------------------

 ------------------------------------------------------------------------
  rules/Privatization/Guard/ParentPropertyLookupGuard.php:131
 ------------------------------------------------------------------------
  - '#Call to deprecated method hasProperty\(\) of class PHPStan\\Reflection\\ClassReflection\:
Use hasInstanceProperty or hasStaticProperty instead#'
  🪪 method.deprecated
 ------------------------------------------------------------------------

 ------------------------------------------------------------------------
  src/NodeManipulator/PropertyManipulator.php:158
 ------------------------------------------------------------------------
  - '#Call to deprecated method hasProperty\(\) of class PHPStan\\Reflection\\ClassReflection\:
Use hasInstanceProperty or hasStaticProperty instead#'
  🪪 method.deprecated
 ------------------------------------------------------------------------

 ------------------------------------------------------------------------
  src/NodeTypeResolver/NodeTypeResolver/PropertyFetchTypeResolver.php:85
 ------------------------------------------------------------------------
  - '#Call to deprecated method hasProperty\(\) of class PHPStan\\Reflection\\ClassReflection\:
Use hasInstanceProperty or hasStaticProperty instead#'
  🪪 method.deprecated
 ------------------------------------------------------------------------

 ------------------------------------------------------------------------
  src/NodeTypeResolver/NodeTypeResolver/PropertyFetchTypeResolver.php:94
 ------------------------------------------------------------------------
  - '#Call to deprecated method getProperty\(\) of class PHPStan\\Reflection\\ClassReflection\:
Use getInstanceProperty or getStaticProperty#'
  🪪 method.deprecated
 ------------------------------------------------------------------------

This needs more carefull look whether it only Property or Static Property.

I am looking into this.

@samsonasik samsonasik self-assigned this Sep 16, 2025
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

The bump PHPStan to 2.1.26 is needed ensure it compatible with new methods in ClassReflection:

  • hasStaticProperty
  • getStaticProperty
  • hasInstanceProperty
  • getInstanceProperty

see new methods:

and PHPStan 2.1.26 release note:

@samsonasik samsonasik merged commit ed32b19 into main Sep 16, 2025
54 of 55 checks passed
@samsonasik samsonasik deleted the bump-phpstan-2126 branch September 16, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant