Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions build/target-repository/bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,6 @@

declare(strict_types=1);

use PHPParser\Node;
use PHPUnit\Runner\Version;

/**
* The preload.php contains 2 dependencies
* - phpstan/phpdoc-parser
* - nikic/php-parser
*
* They need to be loaded early to avoid conflict version between rector prefixed vendor and Project vendor
* For example, a project may use phpstan/phpdoc-parser v1, while rector uses phpstan/phpdoc-parser uses v2, that will error as class or logic are different.
*/
if (
// verify PHPUnit is running
defined('PHPUNIT_COMPOSER_INSTALL')

// no need to preload if Node interface exists
&& ! interface_exists(Node::class, false)

// ensure force autoload version with class_exists() with true argument as not yet loaded
// for phpunit 12+ only
&& class_exists(Version::class, true) && (int) Version::id() >= 12
) {
require_once __DIR__ . '/preload.php';
}

// inspired by https://github.com/phpstan/phpstan/blob/master/bootstrap.php
spl_autoload_register(function (string $class): void {
static $composerAutoloader;
Expand Down
2 changes: 2 additions & 0 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ parameters:
# for config class reflection
- src/Bootstrap/ExtensionConfigResolver.php
- src/Validation/RectorConfigValidator.php
# for phpunit version check
- src/Testing/PHPUnit/AbstractLazyTestCase.php

# use of internal phpstan classes
-
Expand Down
1 change: 1 addition & 0 deletions scoper.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
'exclude-classes' => [
'PHPUnit\Framework\Constraint\IsEqual',
'PHPUnit\Framework\TestCase',
'PHPUnit\Runner\Version',
'PHPUnit\Framework\ExpectationFailedException',

// native class on php 8.3+
Expand Down
9 changes: 8 additions & 1 deletion src/Testing/PHPUnit/AbstractLazyTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Rector\Testing\PHPUnit;

use PHPUnit\Framework\TestCase;
use PHPUnit\Runner\Version;
use Rector\Config\RectorConfig;
use Rector\DependencyInjection\LazyContainerFactory;

Expand Down Expand Up @@ -63,7 +64,13 @@ private function includePreloadFilesAndScoperAutoload(): void
{
if (file_exists(__DIR__ . '/../../../preload.php')) {
if (file_exists(__DIR__ . '/../../../vendor')) {
require_once __DIR__ . '/../../../preload.php';
/**
* On PHPUnit 12+, when classmap autoloaded, it means preload already loaded early
*/
if (! class_exists(Version::class, true) || (int) Version::id() < 12) {
require_once __DIR__ . '/../../../preload.php';
}

// test case in rector split package
} elseif (file_exists(__DIR__ . '/../../../../../../vendor')) {
require_once __DIR__ . '/../../../preload-split-package.php';
Expand Down