[wip] [stmts-aware] kick of custom node parser to use StmtsAwareNode #7640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
commented
Nov 19, 2025
Comment on lines
113
to
116
|
|
||
| dump('unse here'); | ||
| die; | ||
|
|
Member
Author
There was a problem hiding this comment.
It seems the node cannot be If_ and StmtsAwareNode at the same time.
That means we don't see the If_ here. Instead of it's another StmtsAwareNode we'd have to unwrap.
TomasVotruba
changed the title
samsonasik
reviewed
Nov 19, 2025
rules/DeadCode/Rector/If_/RemoveUnusedNonEmptyArrayBeforeForeachRector.php
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-stmts-aware-node
branch
from
9e4be4e to
eecd5c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @staabm I'm trying to replace node with
StmtsAwareNodecustom one. This is my first very raw attempt, no idea how to do it correctly.Any feedback welcomed :)