Skip to content

Conversation

@parijke
Copy link

@parijke parijke commented Nov 28, 2025

This PR removed the dead code from magic methods.

@parijke parijke changed the title feature: add handling for void magic methods feature: remove @return from void magic methods Nov 28, 2025
@parijke parijke changed the title feature: remove @return from void magic methods feature: remove @return void from magic methods Nov 28, 2025
@samsonasik
Copy link
Member

The rule purpose is only remove @return tag when there is native return type.

For removing @return tag when there is no native type, that should be in separate rule so the functionality is isolated, and easy to exclude/skip when needed.

@parijke
Copy link
Author

parijke commented Nov 28, 2025

Can you help me a little then where / how it should be done? This is my forst contributing attempt

@parijke
Copy link
Author

parijke commented Nov 29, 2025

Can you help me a little then where / how it should be done? This is my forst contributing attempt

@samsonasik @TomasVotruba

@samsonasik
Copy link
Member

Add another rule under rules/DeadCode/Rector/ClasaMethod, add test under rules-tests/DeadCode/Rector/ClassMethod as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants