[SYMFONY 5.1] replace Cookie withSameSite argument values with constants (#819)

Author: JohJohan

config/sets/symfony/symfony5/symfony51.php

@@ -16,5 +16,4 @@
     $rectorConfig->import(__DIR__ . '/symfony51/symfony51-inflector.php');
     $rectorConfig->import(__DIR__ . '/symfony51/symfony51-notifier.php');
     $rectorConfig->import(__DIR__ . '/symfony51/symfony51-security-http.php');
-
 };

config/sets/symfony/symfony5/symfony51/symfony51-http-foundation.php

@@ -2,6 +2,8 @@
 
 declare(strict_types=1);
 
+use Rector\Arguments\Rector\ClassMethod\ReplaceArgumentDefaultValueRector;
+use Rector\Arguments\ValueObject\ReplaceArgumentDefaultValue;
 use Rector\Config\RectorConfig;
 use Rector\Transform\Rector\StaticCall\StaticCallToNewRector;
 use Rector\Transform\ValueObject\StaticCallToNew;
@@ -13,4 +15,27 @@
         new StaticCallToNew('Symfony\Component\HttpFoundation\RedirectResponse', 'create'),
         new StaticCallToNew('Symfony\Component\HttpFoundation\StreamedResponse', 'create'),
     ]);
+    $rectorConfig->ruleWithConfiguration(ReplaceArgumentDefaultValueRector::class, [
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            'withSameSite',
+            0,
+            'none',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_NONE'
+        ),
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            'withSameSite',
+            0,
+            'lax',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_LAX'
+        ),
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            'withSameSite',
+            0,
+            'strict',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_STRICT'
+        ),
+    ]);
 };

tests/Set/Symfony51/Fixture/replace_cookie_with_same_site_parameter_value.php.inc

@@ -0,0 +1,38 @@
+<?php
+
+namespace Rector\Symfony\Tests\Set\Symfony51\Fixture;
+
+use Symfony\Component\HttpFoundation\Cookie;
+
+class ReplaceCookieWithSameSiteParameterValue
+{
+    public function run()
+    {
+        $cookie = Cookie::create('name');
+        $cookie->withSameSite('none');
+
+        return $cookie;
+    }
+}
+
+?>
+
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Set\Symfony51\Fixture;
+
+use Symfony\Component\HttpFoundation\Cookie;
+
+class ReplaceCookieWithSameSiteParameterValue
+{
+    public function run()
+    {
+        $cookie = Cookie::create('name');
+        $cookie->withSameSite(\Symfony\Component\HttpFoundation\Cookie::SAMESITE_NONE);
+
+        return $cookie;
+    }
+}
+
+?>

tests/Set/Symfony51/Symfony51Test.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Set\Symfony51;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class Symfony51Test extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/symfony51.php';
+    }
+}

tests/Set/Symfony51/config/symfony51.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Set\SymfonySetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->sets([SymfonySetList::SYMFONY_51]);
+};