[SYMFONY 4.2] replace Cookie argument values with constants (#818)

Author: JohJohan

config/sets/symfony/symfony4/symfony42/symfony42-http-foundation.php

@@ -34,5 +34,34 @@
             null,
             'lax'
         ),
+
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            '__construct',
+            8,
+            'none',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_NONE'
+        ),
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            'create',
+            8,
+            'none',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_NONE'
+        ),
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            'create',
+            8,
+            'lax',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_LAX'
+        ),
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            'create',
+            8,
+            'strict',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_STRICT'
+        ),
     ]);
 };

tests/Set/Symfony42/Fixture/replace_new_cookie_and_create_parameter_value.php.inc

@@ -0,0 +1,36 @@
+<?php
+
+namespace Rector\Symfony\Tests\Set\Symfony42\Fixture;
+
+use Symfony\Component\HttpFoundation\Cookie;
+
+class ReplaceNewCookieAndCreateParameterValue
+{
+    public function run()
+    {
+        $cookie = Cookie::create('name', 'value', 0, '/', null, false, true, false, 'none');
+
+        return new Cookie('name', 'value', 0, '/', null, false, true, false, 'none');
+    }
+}
+
+?>
+
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Set\Symfony42\Fixture;
+
+use Symfony\Component\HttpFoundation\Cookie;
+
+class ReplaceNewCookieAndCreateParameterValue
+{
+    public function run()
+    {
+        $cookie = Cookie::create('name', 'value', 0, '/', null, false, true, false, \Symfony\Component\HttpFoundation\Cookie::SAMESITE_NONE);
+
+        return \Symfony\Component\HttpFoundation\Cookie::create('name', 'value', 0, '/', null, false, true, false, \Symfony\Component\HttpFoundation\Cookie::SAMESITE_NONE);
+    }
+}
+
+?>

tests/Set/Symfony42/Symfony42Test.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Set\Symfony42;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class Symfony42Test extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/symfony42.php';
+    }
+}

tests/Set/Symfony42/config/symfony42.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Set\SymfonySetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->sets([SymfonySetList::SYMFONY_42]);
+};