NarrowPrivateClassMethodParamTypeRule: Skip variadics #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jul 23, 2025
| $this->takesVariadic(...$arr); | ||
| } | ||
|
|
||
| private function takesVariadic(Node ...$node) |
Contributor
Author
There was a problem hiding this comment.
before this PR, this test on line 18 got the following error:
Parameter 1 should use "array<int, PhpParser\Node>" type as the only type passed to this method
as the error-message suggested phpdoc type does not provide more information, than the native type already has, I suggest to drop the error for such cases
samsonasik
approved these changes
Jul 23, 2025
Member
|
Thank you @staabm |
Contributor
Author
|
@samsonasik thanks. since there are more useful changes on the main branch - do you plan a new release in the near future? |
Member
|
/cc @TomasVotruba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.