Feature/rza 250002 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
folder naming convention are easy to distinguish no deep nesetd folder such as
|
recursivezero
requested changes
Jan 15, 2025
| --- | ||
| import StateLayout from "@/layouts/mapLayouts/StateLayout"; | ||
| import stateData from "@/assets/map_assets/stateData.json"; | ||
| import "@/assets/styles/map_styles/stateStyles.css"; |
Owner
There was a problem hiding this comment.
no deep nested folder inside styles just use /styles/map.css
| const { title = "Indian Classical Dance" } = Astro.props; | ||
| --- | ||
|
|
||
| <html lang="en"> |
Owner
There was a problem hiding this comment.
no HTML body head tag again; use BaseLayput and adjust code accordingly
| }); | ||
| </script> | ||
|
|
||
| <style> |
| "image": "himachal.jpg", | ||
| "svg": "HimachalPradesh.svg", | ||
| "wikiLink": "https://en.wikipedia.org/wiki/Himachal_Pradesh", | ||
| "official_website": "https://himachal.nic.in", |
Owner
There was a problem hiding this comment.
Suggested change
| "official_website": "https://himachal.nic.in", | |
| "official_website": "https://himachal.gov.in", |
| "image": "bihar.jpeg", | ||
| "svg": "Bihar.svg", | ||
| "wikiLink": "https://en.wikipedia.org/wiki/Bihar", | ||
| "official_website": "https://state.bihar.gov.in", |
Owner
There was a problem hiding this comment.
Suggested change
| "official_website": "https://state.bihar.gov.in", | |
| "official_website": "https://www.bihar.gov.in", |
| "image": "delhi.jpg", | ||
| "svg": "Delhi.svg", | ||
| "wikiLink": "https://en.wikipedia.org/wiki/Delhi", | ||
| "official_website": "https://delhi.gov.in", |
| </div> | ||
|
|
||
| <script define:vars={{ statesData }}> | ||
| document.addEventListener("DOMContentLoaded", async () => { |
Owner
There was a problem hiding this comment.
use astro page load event astro:page-load
check this https://docs.astro.build/en/guides/view-transitions/#lifecycle-events
and use <ViewTransition/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added India-Map Component
Description
This pull request adds improvements to the India map project in Astro, including updates to the CSS for better responsiveness, enhancements to the SVG map layout, and integration of JSON data for displaying state-specific folk dances. The changes aim to provide a smoother user experience and better visuals across devices.
Fixes #14 (Improve SVG and image layout responsiveness)
Current Issue
Facing problem in dynamic routing from the pop-up to the a specific state page.
Example : A state with a single word like 'Goa', routing is efficient but for a state with two words like "Andhra Pradesh" , routing is inefficient as the space between the words is not processed properly.
Current Fix
Using a
slug fieldin the JSON file with the state's name in lowercase and no spaces.Example- Andhra Pradesh ⟶ andhrapradesh
How Has This Been Tested?
The changes have been tested using the following methods:
Test Configuration:
Checklist
Additional Notes
These changes ensure the map project aligns with the goals of a visually appealing, responsive, and content-rich web experience for showcasing Indian folk dances.