Skip to content

spec: Fix compatibility with Ruby 3.4.0 in ranges #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 4 commits into from
May 7, 2025
Merged

spec: Fix compatibility with Ruby 3.4.0 in ranges #191

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9121520
Fix compatibility with Ruby 3.4.0 in ranges
annzenkina Jan 2, 2025
76f1dfb
Use (-1..0).step(-1) instead of (nil..nil).step(-1)
mrkn Apr 9, 2025
61ba3ef
Revert changes
kou May 7, 2025
58cc138
Fix step behavior for beginless ranges in Ruby 3.4+
kojix2 May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion spec/pycall/pyobject_wrapper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,11 @@ module PyCall
list = PyCall::List.new([*1..10])
expect(list[(1..-1).step(2)]).to eq(PyCall::List.new([2, 4, 6, 8, 10]))
expect(list[(1..-2).step(2)]).to eq(PyCall::List.new([2, 4, 6, 8]))
expect(list[(nil..nil).step(-1)]).to eq(PyCall::List.new([*1..10].reverse))
expect(list[(-1..0).step(-1)]).to eq(PyCall::List.new([*1..10].reverse))
# In Ruby 3.4+, step for non-numeric beginless ranges raises ArgumentError
if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3.4.0')
expect(list[(nil..nil).step(-1)]).to eq(PyCall::List.new([*1..10].reverse))
end
expect(list[(-1...0).step(-1)]).to eq(PyCall::List.new([*2..10].reverse))
expect(list[(-2..2).step(-2)]).to eq(PyCall::List.new([9, 7, 5, 3]))
expect(list[(-2...2).step(-2)]).to eq(PyCall::List.new([9, 7, 5]))
Expand Down
Loading