Skip to content

skip PDF export for s390x in jupyter minimal (3.11/3.12) #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: rhoai-2.23-multi-arch-poc
Choose a base branch
from
Open

skip PDF export for s390x in jupyter minimal (3.11/3.12) #1329

wants to merge 1 commit into from
+16 −0

Conversation

Nash-123
Copy link

Summary
This PR disables PDF export functionality for s390x (IBM Z) architecture in Jupyter Minimal images for both Python 3.11 and 3.12 versions due to known compatibility issues with this feature on s390x.

Changes Made

  • Modified jupyter/utils/install_pdf_deps.sh
  • Added early exit for s390x architecture detection using uname -m
  • PDF export dependencies (TexLive and Pandoc) are now skipped for s390x
    Updated ci/cached-builds/gen_gha_matrix_jobs.py
  • Added jupyter-minimal-ubi9-python-3.11 and jupyter-minimal-ubi9-python-3.12 to S390X_COMPATIBLE set
  • Enables s390x builds for these minimal Jupyter images in CI pipeline
    Modified tests/containers/workbenches/jupyterlab/jupyterlab_test.py
  • Added architecture detection to test_pdf_export test
  • Test now skips PDF export functionality for s390x architecture
  • Prevents test failures on s390x where PDF export is intentionally disabled

@Nash-123 Nash-123 self-assigned this Jul 30, 2025
@openshift-ci openshift-ci bot requested review from atheo89 and paulovmr July 30, 2025 22:47
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jstourac for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Nash-123 Nash-123 requested a review from wznoinsk July 30, 2025 23:19
moulalis pushed a commit to moulalis/notebooks that referenced this pull request Aug 4, 2025
@jiridanek
Revert "RHOAIENG-16076: tests(gha): pre-pull trivy vulnerabilities db…
c4910e0 
… to prevent failures to download later (red-hat-data-services#777)" (red-hat-data-services#1329)

This reverts commit 6477ed4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 Awaiting requested review from atheo89

@paulovmr paulovmr Awaiting requested review from paulovmr

@wznoinsk wznoinsk Awaiting requested review from wznoinsk

Assignees

@Nash-123 Nash-123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nash-123